removed duplicate calls to export buckets

[ArnabChatterjee20k]

removed duplicate calls to export buckets

Summary by CodeRabbit

• Bug Fixes
  • Fixed an issue that could trigger bucket exports twice during Appwrite migrations when bucket resources were included. Buckets and files are now exported exactly once, preventing duplicate data and reducing potential errors.
  • Streamlined the export flow without changing behavior for file exports or other resources.

[coderabbitai]

Walkthrough

Removed a duplicate bucket-export block in Appwrite migration’s exportGroupStorage. The method now attempts BUCKET export once and FILE export once, preserving existing error handling for each. Eliminated the trailing redundant try-catch that could trigger a second bucket export.

Changes

Cohort / File(s)	Summary
Appwrite migration flow src/Migration/Sources/Appwrite.php	Deleted a redundant BUCKET export block and its try-catch. Retained single BUCKET export in the initial block and single FILE export in its block. Simplified control flow; no public API signature changes.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Caller
  participant Appwrite as Appwrite::exportGroupStorage
  participant Buckets as exportBuckets
  participant Files as exportFiles

  Caller->>Appwrite: exportGroupStorage(resources)
  alt resources include BUCKET
    Appwrite->>Buckets: exportBuckets()
    Buckets-->>Appwrite: result or error
    note over Appwrite: Handle errors (once)
  end
  alt resources include FILE
    Appwrite->>Files: exportFiles()
    Files-->>Appwrite: result or error
    note over Appwrite: Handle errors
  end
  Appwrite-->>Caller: done

  %% Change highlight
  rect rgba(235, 248, 255, 0.6)
  note over Appwrite: Removed former<br/>duplicate BUCKET export block
  end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A hop, a stop—no double dip,
One bucket trip, a tidy script.
Files in line, the paths are clear,
Fewer loops for us to steer.
Thump-thump! I stamp with cheer—
Clean burrow, streamlined gear. 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d24d77a and 0ded32f.

📒 Files selected for processing (1)

• src/Migration/Sources/Appwrite.php (0 hunks)

💤 Files with no reviewable changes (1)

• src/Migration/Sources/Appwrite.php

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch dat-664

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

src/Migration/Sources/CSV.php (2)

36-37: Clarify naming of new fields; consider immutability.

• Names “databaseInternalId”/“tableInternalId” don’t align with Resource::setSequence(...). Consider “databaseSequence”/“tableSequence” for consistency.
• If these never change post-construction, make them readonly to enforce invariants.

---

318-325: Confirm whether Row sequence is required.
PR objective mentions “database, table, and row resources,” but only Database/Table sequences are set. If Row also needs a sequence, confirm the intended source (e.g., line number, a separate rowInternalId, or leave unset). If not required, align the PR description accordingly.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 0e4499d and d24d77a.

📒 Files selected for processing (1)

• src/Migration/Sources/CSV.php (3 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

src/Migration/Sources/CSV.php (2)

src/Migration/Resource.php (1)

• setSequence (156-161)

src/Migration/Resources/Database/Table.php (1)

• Table (8-110)

🔇 Additional comments (1)

src/Migration/Sources/CSV.php (1)

45-52: Verify CSV constructor usage and BC impact
I couldn't locate any direct new CSV( call sites; please manually verify dynamic instantiation, factory usages, or dependency-injection to ensure this signature change doesn’t break existing code.