Skip to content

fix: update database property type to nullable and handle defaults in… #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abnegate merged 2 commits into from
Mar 19, 2026
Merged

fix: update database property type to nullable and handle defaults in… #166

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5cebfa
fix: update database property type to nullable and handle defaults in…
ArnabChatterjee20k Mar 19, 2026
adc6393
Update src/Migration/Resources/Database/Database.php
ArnabChatterjee20k Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Migration/Resources/Database/Database.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public function __construct(
protected bool $enabled = true,
protected string $originalId = '',
protected string $type = '',
protected string $database = ''
protected ?string $database = ''
) {
$this->id = $id;
}
Expand All @@ -52,7 +52,7 @@ public static function fromArray(array $array): self
enabled: $array['enabled'] ?? true,
originalId: $array['originalId'] ?? '',
type: $array['type'] ?? 'legacy',
database: $array['database']
database: $array['database'] ?? null
);
}

Expand Down Expand Up @@ -97,7 +97,7 @@ public function getType(): string
return $this->type;
}

public function getDatabase(): string
public function getDatabase(): mixed
Comment thread
ArnabChatterjee20k marked this conversation as resolved.
Outdated
{
return $this->database;
}
Expand Down
Loading