Skip to content

CSV stricter checks #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abnegate merged 3 commits into from
Apr 17, 2025
Merged

CSV stricter checks #75

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81de3b3
update: add stricter checks for column/attribute checks.
ItzNotABug Apr 17, 2025
3c186a1
fix: passed invalid variable for checks.
ItzNotABug Apr 17, 2025
0bcb3f8
fix: need to check the keys!
ItzNotABug Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions src/Migration/Sources/CSV.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,9 +166,15 @@ private function exportDocuments(int $batchSize): void
return;
}

$this->validateCSVHeaders($headers, $attributeTypes);

$buffer = [];

while (($row = fgetcsv($stream)) !== false) {
if (count($row) !== count($headers)) {
throw new \Exception('CSV row does not match the number of header columns.');
}

$data = array_combine($headers, $row);
if ($data === false) {
continue;
Expand Down Expand Up @@ -277,4 +283,34 @@ private function withCsvStream(callable $fn): void
fclose($stream);
}
}

/**
* @throws \Exception
*/
private function validateCSVHeaders(array $headers, array $attributeTypes): void
{
$expectedAttributes = array_keys($attributeTypes);

// Ignore keys like $id, $permissions, etc.
$filteredHeaders = array_filter($headers, fn ($key) => ! str_starts_with($key, '$'));

$extraAttributes = array_diff($filteredHeaders, $expectedAttributes);
$missingAttributes = array_diff($expectedAttributes, $filteredHeaders);

if (! empty($missingAttributes) || ! empty($extraAttributes)) {
$messages = [];

if (! empty($missingAttributes)) {
$label = count($missingAttributes) === 1 ? 'Missing attribute' : 'Missing attributes';
$messages[] = "{$label}: '".implode("', '", $missingAttributes)."'";
}

if (! empty($extraAttributes)) {
$label = count($extraAttributes) === 1 ? 'Unexpected attribute' : 'Unexpected attributes';
$messages[] = "{$label}: '".implode("', '", $extraAttributes)."'";
}

throw new \Exception('CSV header mismatch. '.implode(' | ', $messages));
}
}
}