index migration issue from 1.6.0 to 1.6.x#76
Merged
christyjacob4 merged 4 commits intoApr 22, 2025
Merged
Conversation
…ation for backward compatibility
ItzNotABug
reviewed
Apr 18, 2025
fogelito
reviewed
Apr 20, 2025
| $response = $this->database->listIndexes($collection, $queries); | ||
|
|
||
| foreach ($response as $index) { | ||
| $createdAt = $index['$createdAt']; |
Contributor
There was a problem hiding this comment.
$index['$createdAt'] Will be a string it maybe nulls not sure, so check for both with isEmpty
$index['$createdAt'] = empty($index['$createdAt']) ? DateTime::now() : $index['$createdAt'];
ArnabChatterjee20k
force-pushed
the
fix/index-migration-issue-from-1.6.0
branch
2 times, most recently
from
483afe7 to
2c43246
Compare
ArnabChatterjee20k
force-pushed
the
fix/index-migration-issue-from-1.6.0
branch
from
2c43246 to
67edeaa
Compare
ItzNotABug
reviewed
Apr 21, 2025
ItzNotABug
approved these changes
Apr 21, 2025
fogelito
approved these changes
Apr 21, 2025
christyjacob4
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We dont have createdAt and updatedAt in 1.6.0 appwrite so during the migration they are turning out to be null
So if they are null turning them to current timestamp
https://linear.app/appwrite/issue/DAT-498/failed-self-hosted-migration