-
Notifications
You must be signed in to change notification settings - Fork 4
Fix new terminology #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
bdd4b9f
Remove legacy type from DB group
abnegate 4c5423c
Fix index create
abnegate 7c00ac4
Add missing fallbacks
abnegate 98c9972
Add missing fallbacks
abnegate cf1e3c5
Fix relationships
abnegate f7c948a
Remove redundant double check
abnegate abb1c92
Fallbacks
abnegate 65399a1
Fix relationships
abnegate File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,11 +40,6 @@ class Transfer | |
| Resource::TYPE_INDEX, | ||
| Resource::TYPE_COLUMN, | ||
| Resource::TYPE_ROW, | ||
|
|
||
| // legacy | ||
| Resource::TYPE_DOCUMENT, | ||
| Resource::TYPE_ATTRIBUTE, | ||
| Resource::TYPE_COLLECTION, | ||
|
Comment on lines
-43
to
-47
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Having these here just duplicates what were store in the migrations |
||
| ]; | ||
|
|
||
| public const GROUP_SETTINGS_RESOURCES = []; | ||
|
|
@@ -142,7 +137,7 @@ public function getStatusCounters(): array | |
|
|
||
| foreach ($this->cache->getAll() as $resourceType => $resources) { | ||
| foreach ($resources as $resource) { | ||
| if ($resourceType === Resource::TYPE_ROW && is_string($resource)) { | ||
| if (($resourceType === Resource::TYPE_ROW || $resourceType === Resource::TYPE_DOCUMENT) && is_string($resource)) { | ||
| $rowStatus = $resource; | ||
| $status[$resourceType][$rowStatus]++; | ||
|
|
||
|
|
@@ -286,7 +281,7 @@ public function getReport(string $statusLevel = ''): array | |
|
|
||
| foreach ($cache as $type => $resources) { | ||
| foreach ($resources as $id => $resource) { | ||
| if ($type === Resource::TYPE_ROW && is_string($resource)) { | ||
| if (($type === Resource::TYPE_ROW || $type === Resource::TYPE_DOCUMENT) && is_string($resource)) { | ||
| if ($statusLevel && $resource !== $statusLevel) { | ||
| continue; | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.