(fix): Resolve all PHPStan max-level errors

Author: abnegate

src/Adapter.php

@@ -207,9 +207,16 @@ public function route(string $resourceId): ConnectionResult
         try {
             if ($this->callback !== null) {
                 $resolved = ($this->callback)($resourceId);
-                $result = $resolved instanceof Resolver\Result
-                    ? $resolved
-                    : new Resolver\Result(endpoint: (string) $resolved);
+                if ($resolved instanceof Resolver\Result) {
+                    $result = $resolved;
+                } elseif (\is_string($resolved)) {
+                    $result = new Resolver\Result(endpoint: $resolved);
+                } else {
+                    throw new ResolverException(
+                        'Resolve callback must return Result or string',
+                        ResolverException::INTERNAL
+                    );
+                }
             } elseif ($this->resolver !== null) {
                 $result = $this->resolver->resolve($resourceId);
             } else {

src/Server/TCP/Swoole.php

@@ -88,6 +88,7 @@ public function __construct(
 
         // Build Config from array or named params
         if (\is_array($config)) {
+            /** @var array{host?: string, ports?: array<int, int>, workers?: int, max_connections?: int, max_coroutine?: int, socket_buffer_size?: int, buffer_output_size?: int, reactor_num?: int|null, dispatch_mode?: int, enable_reuse_port?: bool, backlog?: int, package_max_length?: int, tcp_keepidle?: int, tcp_keepinterval?: int, tcp_keepcount?: int, enable_coroutine?: bool, max_wait_time?: int, log_level?: int, log_connections?: bool, recv_buffer_size?: int, backend_connect_timeout?: float, skip_validation?: bool, read_write_split?: bool, tls?: TLS|null, adapter_factory?: \Closure|null} $config */
             $this->config = self::buildConfig($config, $host, $ports, $workers);
         } elseif ($config instanceof Config) {
             $this->config = $config;
@@ -138,9 +139,8 @@ public function __construct(
     }
 
     /**
-     * Build a Config object from an associative array of settings
-     *
-     * @param  array<string, mixed>  $settings
+     * @param  array{host?: string, ports?: array<int, int>, workers?: int, max_connections?: int, max_coroutine?: int, socket_buffer_size?: int, buffer_output_size?: int, reactor_num?: int|null, dispatch_mode?: int, enable_reuse_port?: bool, backlog?: int, package_max_length?: int, tcp_keepidle?: int, tcp_keepinterval?: int, tcp_keepcount?: int, enable_coroutine?: bool, max_wait_time?: int, log_level?: int, log_connections?: bool, recv_buffer_size?: int, backend_connect_timeout?: float, skip_validation?: bool, read_write_split?: bool, tls?: TLS|null, adapter_factory?: \Closure|null}  $settings
+     * @param  array<int, int>|null  $ports
      */
     protected static function buildConfig(
         array $settings,
@@ -244,6 +244,7 @@ public function onWorkerStart(Server $server, int $workerId): void
         // Initialize TCP adapter per worker per port
         foreach ($this->config->ports as $port) {
             if ($this->config->adapterFactory !== null) {
+                /** @var TCPAdapter $adapter */
                 $adapter = ($this->config->adapterFactory)($port);
             } else {
                 $adapter = new TCPAdapter($this->resolver, port: $port);

tests/AdapterFactoryTest.php

@@ -38,7 +38,9 @@ public function testAdapterFactoryClosureIsInvokable(): void
         };
 
         $config = new Config(adapterFactory: $factory);
-        $result = ($config->adapterFactory)(5432);
+        $callable = $config->adapterFactory;
+        \assert($callable !== null);
+        $result = $callable(5432);
         $this->assertSame('adapter-for-port-5432', $result);
     }
 
@@ -51,9 +53,11 @@ public function testAdapterFactoryClosureReceivesPort(): void
         };
 
         $config = new Config(adapterFactory: $factory);
-        ($config->adapterFactory)(5432);
-        ($config->adapterFactory)(3306);
-        ($config->adapterFactory)(27017);
+        $callable = $config->adapterFactory;
+        \assert($callable !== null);
+        $callable(5432);
+        $callable(3306);
+        $callable(27017);
 
         $this->assertSame([5432, 3306, 27017], $receivedPorts);
     }

tests/OnResolveCallbackTest.php

@@ -156,18 +156,17 @@ public function testCallbackTakesPriorityOverResolver(): void
     {
         $resolverCalled = false;
 
-        $mockResolver = new class ($resolverCalled) extends MockResolver {
-            private bool $called;
+        $mockResolver = new class extends MockResolver {
+            public bool $wasCalled = false;
 
-            public function __construct(bool &$called)
+            public function __construct()
             {
-                $this->called = &$called;
                 parent::setEndpoint('resolver.example.com:8080');
             }
 
             public function resolve(string $resourceId): \Utopia\Proxy\Resolver\Result
             {
-                $this->called = true;
+                $this->wasCalled = true;
                 return parent::resolve($resourceId);
             }
         };
@@ -181,7 +180,7 @@ public function resolve(string $resourceId): \Utopia\Proxy\Resolver\Result
         $result = $adapter->route('test-resource');
 
         $this->assertSame('callback.example.com:8080', $result->endpoint);
-        $this->assertFalse($resolverCalled);
+        $this->assertFalse($mockResolver->wasCalled);
     }
 
     /**