chore(tests): remove exercise-only tests; collapse duplicates; extract ClickHouseTestCase

Test cleanup pass on the files added by this PR.

Removed:
- testDualReadSamplerActivates (events + gauges variants) — these
  asserted the route log fired after enabling the sampler but never
  proved the sampler did anything; the divergence / agreement tests
  cover the actual behaviour.

Collapsed via @dataProvider:
- testTopNBy{Path,Country,Service,MethodStatus}RoutesToMv → single
  testTopNGroupedQueryRoutesToMatchingMv with 4 provider entries.
- testTopGaugesBy{Service,Resource}RoutesToMv → single
  testTopGaugesGroupedQueryRoutesToMatchingMv with 2 provider entries.

Extracted ClickHouseTestCase base class:
- makeAdapter() centralizes the 6 env-var lookup + setNamespace +
  setSharedTables block duplicated across all six new test files.
- databaseName() reads the private `database` property.
- resolveTableName() invokes a private accessor returning a table name.
- queryRaw() invokes the private query() entry point.

The base namespace `Utopia\Tests\Usage\Adapter` reflects the actual
on-disk path, so PSR-4 resolves it without a classmap entry.

Also dropped a handful of rationale comments and unused `use
ReflectionClass` imports made redundant by the helper methods.

Net: -484 / +118 in the existing files, +86 in the new base. Total
delta -280 test LOC, -2 tests (258 vs 260) while gaining coverage
from the dataProvider expansions.

Author: lohanidamodar

tests/Usage/Adapter/ClickHouseDimRollupTest.php

@@ -2,9 +2,8 @@
 
 namespace Utopia\Tests\Adapter;
 
-use PHPUnit\Framework\TestCase;
-use ReflectionClass;
 use Utopia\Query\Query;
+use Utopia\Tests\Usage\Adapter\ClickHouseTestCase;
 use Utopia\Usage\Adapter\ClickHouse as ClickHouseAdapter;
 use Utopia\Usage\Usage;
 
@@ -13,7 +12,7 @@
  * by_service / by_method_status) is created by setup() and that writes to
  * the raw events table fan out into each rollup table.
  */
-class ClickHouseDimRollupTest extends TestCase
+class ClickHouseDimRollupTest extends ClickHouseTestCase
 {
     private Usage $usage;
 
@@ -29,21 +28,7 @@ class ClickHouseDimRollupTest extends TestCase
 
     protected function setUp(): void
     {
-        $host = getenv('CLICKHOUSE_HOST') ?: 'clickhouse';
-        $username = getenv('CLICKHOUSE_USER') ?: 'default';
-        $password = getenv('CLICKHOUSE_PASSWORD') ?: 'clickhouse';
-        $port = (int) (getenv('CLICKHOUSE_PORT') ?: 8123);
-        $secure = (bool) (getenv('CLICKHOUSE_SECURE') ?: false);
-
-        $this->adapter = new ClickHouseAdapter($host, $username, $password, $port, $secure);
-        $this->adapter->setNamespace('utopia_usage_dim_rollup');
-        $this->adapter->setSharedTables(true);
-        $this->adapter->setTenant('1');
-
-        if ($database = getenv('CLICKHOUSE_DATABASE')) {
-            $this->adapter->setDatabase($database);
-        }
-
+        $this->adapter = $this->makeAdapter('utopia_usage_dim_rollup');
         $this->usage = new Usage($this->adapter);
         $this->usage->setup();
         $this->usage->purge();
@@ -87,9 +72,6 @@ public function testWritesPropagateToEachRollup(): void
             ],
         ], Usage::TYPE_EVENT));
 
-        // MVs are synchronous on insert by default in ClickHouse, but the
-        // SummingMergeTree won't merge identical sort keys until background
-        // merges run — we count rows, not sum, to check propagation.
         foreach ($this->rollups as $rollup) {
             $table = $this->getDimRollupTable($rollup['name']);
             $count = $this->countRows($table);
@@ -124,9 +106,6 @@ public function testPurgeByIdFiltersDropAllRollupRowsForThatDay(): void
             ['metric' => $metric, 'value' => 11, 'tags' => ['path' => '/v1/x', 'method' => 'GET', 'status' => '200', 'service' => 'storage', 'country' => 'us']],
         ], Usage::TYPE_EVENT));
 
-        // id only exists on raw events — rollups don't store it. The purge
-        // helper must NOT attempt `WHERE id = ...` against the rollups; it
-        // should fall through to whole-day deletion.
         $this->usage->purge([
             Query::equal('metric', [$metric]),
             Query::equal('id', ['nonexistent-id']),
@@ -151,10 +130,6 @@ public function testPurgeByPathClearsAllRollupsForThatDay(): void
             ['metric' => $metric, 'value' => 7, 'tags' => ['path' => '/v1/x', 'method' => 'GET', 'status' => '200', 'service' => 'storage', 'country' => 'us']],
         ], Usage::TYPE_EVENT));
 
-        // Purge by a column (path) that only the by_path rollup stores.
-        // Cross-dim rollups (by_country, by_service, by_method_status) cannot
-        // narrow by path, but they must still drop their stale row for the
-        // affected day or routed reads will over-report.
         $this->usage->purge([
             Query::equal('metric', [$metric]),
             Query::equal('path', ['/v1/x']),
@@ -173,49 +148,26 @@ public function testPurgeByPathClearsAllRollupsForThatDay(): void
 
     private function getDimRollupTable(string $name): string
     {
-        $reflection = new ReflectionClass($this->adapter);
-        $method = $reflection->getMethod('getDimRollupTableName');
-        $method->setAccessible(true);
-        $raw = $method->invoke($this->adapter, $name);
-        return is_string($raw) ? $raw : '';
+        return $this->resolveTableName($this->adapter, 'getDimRollupTableName', [$name]);
     }
 
     private function tableExists(string $table): bool
     {
-        $reflection = new ReflectionClass($this->adapter);
-        $dbProp = $reflection->getProperty('database');
-        $dbProp->setAccessible(true);
-        $databaseValue = $dbProp->getValue($this->adapter);
-        $database = is_string($databaseValue) ? $databaseValue : '';
-
-        $sql = "EXISTS TABLE `{$database}`.`{$table}` FORMAT JSON";
-        $query = $reflection->getMethod('query');
-        $query->setAccessible(true);
-        $raw = $query->invoke($this->adapter, $sql, []);
-        $rawString = is_string($raw) ? $raw : '';
-        $json = json_decode($rawString, true);
+        $database = $this->databaseName($this->adapter);
+        $raw = $this->queryRaw($this->adapter, "EXISTS TABLE `{$database}`.`{$table}` FORMAT JSON");
+        $json = json_decode($raw, true);
         if (is_array($json) && isset($json['data'][0]) && is_array($json['data'][0])) {
-            $row = $json['data'][0];
-            $value = $row['result'] ?? 0;
+            $value = $json['data'][0]['result'] ?? 0;
             return ((int) $value) === 1;
         }
         return false;
     }
 
     private function countRows(string $table): int
     {
-        $reflection = new ReflectionClass($this->adapter);
-        $dbProp = $reflection->getProperty('database');
-        $dbProp->setAccessible(true);
-        $databaseValue = $dbProp->getValue($this->adapter);
-        $database = is_string($databaseValue) ? $databaseValue : '';
-
-        $sql = "SELECT count() AS c FROM `{$database}`.`{$table}` FORMAT JSON";
-        $query = $reflection->getMethod('query');
-        $query->setAccessible(true);
-        $raw = $query->invoke($this->adapter, $sql, []);
-        $rawString = is_string($raw) ? $raw : '';
-        $json = json_decode($rawString, true);
+        $database = $this->databaseName($this->adapter);
+        $raw = $this->queryRaw($this->adapter, "SELECT count() AS c FROM `{$database}`.`{$table}` FORMAT JSON");
+        $json = json_decode($raw, true);
         if (is_array($json) && isset($json['data'][0]) && is_array($json['data'][0])) {
             return (int) ($json['data'][0]['c'] ?? 0);
         }
@@ -224,19 +176,11 @@ private function countRows(string $table): int
 
     private function sumValue(string $table, string $metric): int
     {
-        $reflection = new ReflectionClass($this->adapter);
-        $dbProp = $reflection->getProperty('database');
-        $dbProp->setAccessible(true);
-        $databaseValue = $dbProp->getValue($this->adapter);
-        $database = is_string($databaseValue) ? $databaseValue : '';
-
+        $database = $this->databaseName($this->adapter);
         $sql = "SELECT sum(value) AS s FROM `{$database}`.`{$table}` "
             . "WHERE metric = '" . addslashes($metric) . "' FORMAT JSON";
-        $query = $reflection->getMethod('query');
-        $query->setAccessible(true);
-        $raw = $query->invoke($this->adapter, $sql, []);
-        $rawString = is_string($raw) ? $raw : '';
-        $json = json_decode($rawString, true);
+        $raw = $this->queryRaw($this->adapter, $sql);
+        $json = json_decode($raw, true);
         if (is_array($json) && isset($json['data'][0]) && is_array($json['data'][0])) {
             return (int) ($json['data'][0]['s'] ?? 0);
         }