fix(adapter): exclude end-day row from daily route for inclusive-midnight upper bounds

Daily MV rows live at toStartOfDay(time). An inclusive `time <= midnight`
predicate matched the row at that midnight, which represents the entire
day starting at it — so callers received totals that over-included the
end day's data.

Two changes:
- routedSum() translates inclusive `LESSER_EQUAL` time bounds at midnight
  to exclusive `LESSER` before delegating to sumDaily(). BETWEEN with an
  inclusive midnight upper is split into a `>=` lower + `<` upper pair.
- buildDailyTimeFilters() (hybrid path) applies the same translation
  when emitting the daily-branch WHERE clause.

Bench bounds in EventsBench were also relying on current time-of-day,
which prevented bench_events_sum_30d from satisfying the day-aligned
check and routed it to raw despite the route assertion expecting daily.
Floored to UTC midnight so the scenario exercises the path it asserts.

Regression test: seeds an event mid-day on the end day, queries with
inclusive-midnight upper, asserts the daily-routed sum equals the raw
sum (and does not include the late event).

Author: lohanidamodar

src/Usage/Adapter/ClickHouse.php

@@ -2155,7 +2155,7 @@ private function routedSum(array $queries, string $operation): int
         $this->recordRoute($operation, $plan, $route);
 
         if ($route === 'daily') {
-            $total = $this->sumDaily($queries, 'value');
+            $total = $this->sumDaily($this->translateInclusiveMidnightForDaily($queries), 'value');
             $this->maybeDualRead($queries, $route, $plan, $total);
             return $total;
         }
@@ -2334,6 +2334,64 @@ private function isDayAligned(?DateTime $dt): bool
         return $dt->format('H:i:s.u') === '00:00:00.000000';
     }
 
+    private function isMidnightString(?string $ts): bool
+    {
+        if ($ts === null) {
+            return false;
+        }
+        try {
+            return $this->isDayAligned(new DateTime($ts));
+        } catch (Exception $e) {
+            return false;
+        }
+    }
+
+    /**
+     * Daily MV rows are keyed at toStartOfDay(time), so an inclusive
+     * `<= midnight` upper bound matches the row representing the entire
+     * end day and over-counts. Rewrite inclusive-midnight upper bounds
+     * (LESSER_EQUAL and BETWEEN upper) to exclusive `<` for the daily
+     * branch. Other bounds pass through untouched.
+     *
+     * @param array<Query> $queries
+     * @return array<Query>
+     */
+    private function translateInclusiveMidnightForDaily(array $queries): array
+    {
+        $result = [];
+        foreach ($queries as $q) {
+            if (!($q instanceof Query) || $q->getAttribute() !== 'time') {
+                $result[] = $q;
+                continue;
+            }
+            $method = $q->getMethod();
+            $values = $q->getValues();
+
+            if ($method === Query::TYPE_LESSER_EQUAL) {
+                $upper = $this->stringifyTime($values[0] ?? null);
+                if ($upper !== null && $this->isMidnightString($upper)) {
+                    $result[] = new Query(Query::TYPE_LESSER, 'time', [$upper]);
+                    continue;
+                }
+            }
+
+            if ($method === Query::TYPE_BETWEEN && count($values) >= 2) {
+                $upper = $this->stringifyTime($values[1] ?? null);
+                if ($upper !== null && $this->isMidnightString($upper)) {
+                    $lower = $this->stringifyTime($values[0] ?? null);
+                    if ($lower !== null) {
+                        $result[] = new Query(Query::TYPE_GREATER_EQUAL, 'time', [$lower]);
+                    }
+                    $result[] = new Query(Query::TYPE_LESSER, 'time', [$upper]);
+                    continue;
+                }
+            }
+
+            $result[] = $q;
+        }
+        return $result;
+    }
+
     private function stringifyTime(mixed $value): ?string
     {
         if ($value instanceof DateTime) {
@@ -2550,7 +2608,8 @@ private function buildDailyTimeFilters(array $existing, array $timeQueries, arra
                 }
                 $name = 'daily_time_upper_' . $counter++;
                 $params[$name] = $upper;
-                $op = $method === Query::TYPE_LESSER ? '<' : '<=';
+                $inclusiveOnMidnight = $method === Query::TYPE_LESSER_EQUAL && $this->isMidnightString($upper);
+                $op = ($method === Query::TYPE_LESSER || $inclusiveOnMidnight) ? '<' : '<=';
                 $filters[] = '`time` ' . $op . ' {' . $name . ':DateTime64(3, \'UTC\')}';
                 continue;
             }
@@ -2566,7 +2625,8 @@ private function buildDailyTimeFilters(array $existing, array $timeQueries, arra
                 if ($upper !== null) {
                     $name = 'daily_time_upper_' . $counter++;
                     $params[$name] = $upper;
-                    $filters[] = '`time` <= {' . $name . ':DateTime64(3, \'UTC\')}';
+                    $op = $this->isMidnightString($upper) ? '<' : '<=';
+                    $filters[] = '`time` ' . $op . ' {' . $name . ':DateTime64(3, \'UTC\')}';
                 }
                 continue;
             }

tests/Benchmark/EventsBench.php

@@ -20,8 +20,8 @@ protected function setUp(): void
 
     public function testBenchmarks(): void
     {
-        $start = (new DateTime('-30 days'))->format('Y-m-d H:i:s');
-        $end = (new DateTime('-1 day'))->format('Y-m-d H:i:s');
+        $start = (new DateTime('-30 days', new DateTimeZone('UTC')))->setTime(0, 0, 0)->format('Y-m-d H:i:s');
+        $end = (new DateTime('-1 day', new DateTimeZone('UTC')))->setTime(0, 0, 0)->format('Y-m-d H:i:s');
 
         $this->runBench('bench_events_sum_30d', function (string $queryId) use ($start, $end): void {
             $this->adapter->setNextQueryId($queryId);

tests/Usage/Adapter/ClickHouseRoutingTest.php

@@ -86,6 +86,30 @@ public function testClosedDayWindowRoutesToDaily(): void
         $this->assertSame($rawSum, $sum, 'daily MV must re-aggregate to the same total as raw');
     }
 
+    public function testInclusiveMidnightUpperBoundExcludesEndDayOnDailyRoute(): void
+    {
+        $this->adapter->clearRouteLog();
+
+        $this->seedHistoricalRow('routed.metric', 9999, '-2 days +14 hours', ['path' => '/v1/late']);
+
+        $start = (new DateTime('-7 days', new DateTimeZone('UTC')))->setTime(0, 0, 0)->format('Y-m-d H:i:s');
+        $end = (new DateTime('-2 days', new DateTimeZone('UTC')))->setTime(0, 0, 0)->format('Y-m-d H:i:s');
+
+        $rawSum = $this->sumRaw('routed.metric', $start, $end);
+
+        $sum = $this->usage->sum([
+            Query::equal('metric', ['routed.metric']),
+            Query::greaterThanEqual('time', $start),
+            Query::lessThanEqual('time', $end),
+        ], 'value', Usage::TYPE_EVENT);
+
+        $log = $this->adapter->getRouteLog();
+        $this->assertCount(1, $log);
+        $this->assertSame('daily', $log[0]['route']);
+        $this->assertSame($rawSum, $sum, 'daily MV must not include the end-day full-day row for inclusive-midnight upper bounds');
+        $this->assertSame(300, $sum);
+    }
+
     public function testMidDayClosedWindowFallsBackToRaw(): void
     {
         // Daily rows are stored at midnight; a mid-day caller bound