Commit a64128a
refactor(clickhouse): inject client, drop hand-rolled transport config, fix phpstan & oversized URLs
Address review feedback:
- Make the HTTP transport a constructor param (DI); default to a cURL
client with connection reuse. Auth/database move to per-request headers
so an injected client stays a pure transport.
- Remove setTimeout/setKeepAlive/setMaxRetries/setRetryDelay and the
hand-rolled retry engine — these are now the injected client's concern
(e.g. Utopia\Client\Decorator\Retry). Trim getConnectionStats accordingly.
- Remove setCompression and the gzip Accept-Encoding header.
- Send query + param_* as multipart/form-data instead of URL query string,
fixing HTTP 414 on large equal/tag filters (restores the pre-migration
transport shape ClickHouse parses).
- Delete phpstan-baseline.neon and fix all level-max errors (typed
decodeRows + guarded scalar coercions); bump composer check memory limit.
- Pin Dockerfile base image to php:8.4.22-cli-alpine3.24; add ext-curl to
composer suggest.
- Widen utopia-php/client constraint to ^0.1|^0.2.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 6513436 commit a64128a
15 files changed
Lines changed: 257 additions & 1002 deletions
File tree
- src/Usage/Adapter
- tests
- Benchmark
- Usage
- Adapter
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
32 | 35 | | |
33 | 36 | | |
34 | 37 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | 1 | | |
5 | 2 | | |
6 | 3 | | |
| |||
0 commit comments