greptile feedback

Author: hmacr

src/VCS/Adapter/Git/GitHub.php

@@ -989,8 +989,13 @@ public function getEvent(string $event, string $payload): array
                 $baseLogin = $payloadPullRequestBaseUser['login'] ?? '';
                 $external = $headLogin !== $baseLogin;
 
-                $prFiles = $this->getPullRequestFiles($owner, $repositoryName, (int)$pullRequestNumber);
-                $affectedFiles = array_column($prFiles, 'filename');
+                try {
+                    $prFiles = $this->getPullRequestFiles($owner, $repositoryName, (int)$pullRequestNumber);
+                    $affectedFiles = array_column($prFiles, 'filename');
+                } catch (Exception $e) {
+                    // In case of any error while fetching pull request files, we will return an empty list of affected files.
+                    $affectedFiles = [];
+                }
 
                 return [
                     'branch' => $branch,

src/VCS/Adapter/Git/Gitea.php

@@ -1037,8 +1037,12 @@ public function getEvent(string $event, string $payload): array
                 $baseRepoFullName = $payloadRepository['full_name'] ?? '';
                 $external = !empty($headRepoFullName) && !empty($baseRepoFullName) && $headRepoFullName !== $baseRepoFullName;
 
-                $prFiles = $this->getPullRequestFiles($owner, $repositoryName, (int)$pullRequestNumber);
-                $affectedFiles = array_column($prFiles, 'filename');
+                try {
+                    $prFiles = $this->getPullRequestFiles($owner, $repositoryName, (int)$pullRequestNumber);
+                    $affectedFiles = array_column($prFiles, 'filename');
+                } catch (Exception $e) {
+                    $affectedFiles = [];
+                }
 
                 return [
                     'branch' => $branch,

tests/VCS/Adapter/GiteaTest.php

@@ -962,9 +962,19 @@ public function testGetEventPullRequest(): void
             'sender' => ['html_url' => "{$giteaUrl}/" . self::$owner],
         ]);
 
+        if ($payload === false) {
+            $this->fail('Failed to encode JSON payload');
+        }
+
         $result = $this->vcsAdapter->getEvent('pull_request', $payload);
 
         $this->assertIsArray($result);
+        $this->assertArrayHasKey('branch', $result);
+        $this->assertArrayHasKey('pullRequestNumber', $result);
+        $this->assertArrayHasKey('action', $result);
+        $this->assertArrayHasKey('commitHash', $result);
+        $this->assertArrayHasKey('external', $result);
+
         $this->assertSame('feature-branch', $result['branch']);
         $this->assertSame($prNumber, $result['pullRequestNumber']);
         $this->assertSame('opened', $result['action']);
@@ -1018,6 +1028,10 @@ public function testGetEventPullRequestExternal(): void
             'sender' => ['html_url' => "{$giteaUrl}/external-user"],
         ]);
 
+        if ($payload === false) {
+            $this->fail('Failed to encode JSON payload');
+        }
+
         $result = $this->vcsAdapter->getEvent('pull_request', $payload);
 
         $this->assertTrue($result['external']);