updated with suggestions

Author: jaysomani

tests/VCS/Adapter/ForgejoTest.php

@@ -18,11 +18,6 @@ class ForgejoTest extends GiteaTest
     protected string $webhookSignatureHeader = 'X-Forgejo-Signature';
     protected string $avatarDomain = 'http://localhost:3000/avatars/';
 
-    protected function createVCSAdapter(): Git
-    {
-        return new Forgejo(new Cache(new None()));
-    }
-
     public function setupAdapter(): void
     {
         if (empty(static::$accessToken)) {

tests/VCS/Adapter/GitHubTest.php

@@ -16,11 +16,6 @@ class GitHubTest extends Base
     protected static string $installationId = '';
     protected static string $defaultBranch = 'main';
 
-    protected function createVCSAdapter(): Git
-    {
-        return new GitHub(new Cache(new None()));
-    }
-
     public function setupAdapter(): void
     {
         $privateKey = str_replace('\\n', "\n", System::getEnv('TESTS_GITHUB_PRIVATE_KEY') ?? '');

tests/VCS/Adapter/GitLabTest.php

@@ -15,11 +15,6 @@ class GitLabTest extends Base
     protected static string $owner = '';
     protected static string $defaultBranch = 'main';
 
-    protected function createVCSAdapter(): Git
-    {
-        return new GitLab(new Cache(new None()));
-    }
-
     public function setupAdapter(): void
     {
         if (empty(static::$accessToken)) {
@@ -63,24 +58,6 @@ protected function setupGitLab(): void
     }
 
 
-    public function testGetOwnerNameWithRepositoryId(): void
-    {
-        $repositoryName = 'test-get-owner-name-' . \uniqid();
-        $this->vcsAdapter->createRepository(static::$owner, $repositoryName, false);
-
-        try {
-            $repo = $this->vcsAdapter->getRepository(static::$owner, $repositoryName);
-            $repositoryId = $repo['id'] ?? 0;
-
-            $result = $this->vcsAdapter->getOwnerName('', $repositoryId);
-
-            $this->assertIsString($result);
-            $this->assertNotEmpty($result);
-        } finally {
-            $this->vcsAdapter->deleteRepository(static::$owner, $repositoryName);
-        }
-    }
-
     public function testSearchRepositories(): void
     {
         $repositoryName = 'test-search-repositories-' . \uniqid();

tests/VCS/Adapter/GiteaTest.php

@@ -19,11 +19,6 @@ class GiteaTest extends Base
     protected string $webhookSignatureHeader = 'X-Gitea-Signature';
     protected string $avatarDomain = 'gravatar.com';
 
-    protected function createVCSAdapter(): Git
-    {
-        return new Gitea(new Cache(new None()));
-    }
-
     public function setupAdapter(): void
     {
         if (empty(static::$accessToken)) {

tests/VCS/Adapter/GogsTest.php

@@ -18,11 +18,6 @@ class GogsTest extends GiteaTest
     protected string $avatarDomain = 'gravatar.com';
     protected static string $defaultBranch = 'master';
 
-    protected function createVCSAdapter(): Git
-    {
-        return new Gogs(new Cache(new None()));
-    }
-
     public function setupAdapter(): void
     {
         if (empty(static::$accessToken)) {

tests/VCS/Base.php

@@ -14,8 +14,6 @@ abstract class Base extends TestCase
     protected static string $owner = '';
     protected static string $defaultBranch = 'main';
 
-    abstract protected function createVCSAdapter(): Git;
-
     abstract protected function setupAdapter(): void;
 
     public function setUp(): void
@@ -616,18 +614,21 @@ public function testSearchRepositories(): void
     {
         $repo1Name = 'test-search-repo1-' . \uniqid();
         $repo2Name = 'test-search-repo2-' . \uniqid();
-
+    
         $this->vcsAdapter->createRepository(static::$owner, $repo1Name, false);
         $this->vcsAdapter->createRepository(static::$owner, $repo2Name, false);
-
+    
         try {
-            $result = $this->vcsAdapter->searchRepositories(static::$owner, 1, 10);
-
+            $result = [];
+            $this->assertEventually(function () use (&$result) {
+                $result = $this->vcsAdapter->searchRepositories(static::$owner, 1, 10);
+                $this->assertGreaterThanOrEqual(2, $result['total']);
+            }, 30000, 2000);
+    
             $this->assertIsArray($result);
             $this->assertArrayHasKey('items', $result);
             $this->assertArrayHasKey('total', $result);
-            $this->assertGreaterThanOrEqual(2, $result['total']);
-
+    
             $this->assertArrayHasKey('pushed_at', $result['items'][0]);
             $this->assertTrue(
                 $result['items'][0]['pushed_at'] === null || \strtotime($result['items'][0]['pushed_at']) !== false