Remove loop from listBranches, use page/perPage for single-page fetch

Author: HarshMN2345

src/VCS/Adapter/Git/GitHub.php

@@ -754,28 +754,20 @@ public function listBranches(string $owner, string $repositoryName, int $perPage
     {
         $url = "/repos/$owner/$repositoryName/branches";
         $perPage = min(max($perPage, 1), 100);
-        $names = [];
 
-        do {
-            $response = $this->call(self::METHOD_GET, $url, ['Authorization' => "Bearer $this->accessToken"], [
-                'page' => $page,
-                'per_page' => $perPage,
-            ]);
-
-            $responseBody = $response['body'] ?? [];
-
-            if (!is_array($responseBody)) {
-                break;
-            }
+        $response = $this->call(self::METHOD_GET, $url, ['Authorization' => "Bearer $this->accessToken"], [
+            'page' => $page,
+            'per_page' => $perPage,
+        ]);
 
-            foreach ($responseBody as $subarray) {
-                $names[] = $subarray['name'] ?? '';
-            }
+        $statusCode = $response['headers']['status-code'] ?? 0;
+        $responseBody = $response['body'] ?? [];
 
-            $page++;
-        } while (count($responseBody) === $perPage);
+        if ($statusCode < 200 || $statusCode >= 300 || !is_array($responseBody)) {
+            return [];
+        }
 
-        return $names;
+        return array_values(array_map(fn ($branch) => $branch['name'] ?? '', $responseBody));
     }
 
     /**

tests/VCS/Adapter/GitHubTest.php

@@ -525,7 +525,7 @@ public function testGetCommitWithInvalidHash(): void
         }
     }
 
-    public function testListBranchesFetchesMultiplePages(): void
+    public function testListBranchesPagination(): void
     {
         $repositoryName = 'test-list-branches-pages-' . \uniqid();
         $this->vcsAdapter->createRepository(static::$owner, $repositoryName, false);
@@ -537,12 +537,19 @@ public function testListBranchesFetchesMultiplePages(): void
 
             /** @var GitHub $adapter */
             $adapter = $this->vcsAdapter;
-            $branches = $adapter->listBranches(static::$owner, $repositoryName, 1);
 
-            $this->assertIsArray($branches);
-            $this->assertContains(static::$defaultBranch, $branches);
-            $this->assertContains('branch-a', $branches);
-            $this->assertContains('branch-b', $branches);
+            $page1 = $adapter->listBranches(static::$owner, $repositoryName, 1, 1);
+            $this->assertCount(1, $page1);
+
+            $page2 = $adapter->listBranches(static::$owner, $repositoryName, 1, 2);
+            $this->assertCount(1, $page2);
+
+            $this->assertNotSame($page1[0], $page2[0]);
+
+            $all = $adapter->listBranches(static::$owner, $repositoryName, 100, 1);
+            $this->assertContains(static::$defaultBranch, $all);
+            $this->assertContains('branch-a', $all);
+            $this->assertContains('branch-b', $all);
         } finally {
             $this->vcsAdapter->deleteRepository(static::$owner, $repositoryName);
         }