Address GitHub branch pagination review

Author: HarshMN2345

src/VCS/Adapter/Git/GitHub.php

@@ -733,18 +733,19 @@ public function getPullRequestFromBranch(string $owner, string $repositoryName,
      *
      * @param  string  $owner Owner name of the repository
      * @param  string  $repositoryName Name of the GitHub repository
+     * @param  int  $perPage Number of branches to fetch per page
      * @return array<string> List of branch names as array
      */
-    public function listBranches(string $owner, string $repositoryName): array
+    public function listBranches(string $owner, string $repositoryName, int $perPage = 100): array
     {
         $url = "/repos/$owner/$repositoryName/branches";
-        $perPage = 100;
-        $currentPage = 1;
+        $perPage = min(max($perPage, 1), 100);
+        $page = 1;
         $names = [];
 
         do {
             $response = $this->call(self::METHOD_GET, $url, ['Authorization' => "Bearer $this->accessToken"], [
-                'page' => $currentPage,
+                'page' => $page,
                 'per_page' => $perPage,
             ]);
 
@@ -758,7 +759,7 @@ public function listBranches(string $owner, string $repositoryName): array
                 $names[] = $subarray['name'] ?? '';
             }
 
-            $currentPage++;
+            $page++;
         } while (count($responseBody) === $perPage);
 
         return $names;

tests/VCS/Adapter/GitHubTest.php

@@ -467,58 +467,17 @@ public function testGetCommit(): void
         $this->assertSame('7ae65094d56edafc48596ffbb77950e741e56412', $commitDetails['commitHash']);
     }
 
-    public function testListBranchesFetchesAllPages(): void
+    public function testListBranchesFetchesMultiplePages(): void
     {
-        $firstPage = [];
-        for ($i = 1; $i <= 100; $i++) {
-            $firstPage[] = ['name' => "branch-{$i}"];
-        }
-
-        $secondPage = [];
-        for ($i = 101; $i <= 135; $i++) {
-            $secondPage[] = ['name' => "branch-{$i}"];
-        }
-
-        $adapter = new class (new Cache(new None()), [$firstPage, $secondPage]) extends GitHub {
-            /**
-             * @var array<array<mixed>>
-             */
-            public array $requests = [];
-
-            /**
-             * @param array<array<mixed>> $responses
-             */
-            public function __construct(Cache $cache, private array $responses)
-            {
-                parent::__construct($cache);
-                $this->accessToken = 'test-token';
-            }
-
-            protected function call(string $method, string $path = '', array $headers = [], array $params = [], bool $decode = true)
-            {
-                $this->requests[] = [
-                    'method' => $method,
-                    'path' => $path,
-                    'headers' => $headers,
-                    'params' => $params,
-                ];
-
-                return [
-                    'headers' => ['status-code' => 200],
-                    'body' => array_shift($this->responses) ?? [],
-                ];
-            }
-        };
+        $this->assertInstanceOf(GitHub::class, $this->vcsAdapter);
 
-        $branches = $adapter->listBranches('appwrite', 'appwrite');
+        /** @var GitHub $adapter */
+        $adapter = $this->vcsAdapter;
+        $branches = $adapter->listBranches('test-kh', 'test1', 1);
 
-        $this->assertCount(135, $branches);
-        $this->assertSame('branch-1', $branches[0]);
-        $this->assertSame('branch-135', $branches[134]);
-        $this->assertCount(2, $adapter->requests);
-        $this->assertSame('/repos/appwrite/appwrite/branches', $adapter->requests[0]['path']);
-        $this->assertSame(['page' => 1, 'per_page' => 100], $adapter->requests[0]['params']);
-        $this->assertSame(['page' => 2, 'per_page' => 100], $adapter->requests[1]['params']);
+        $this->assertIsArray($branches);
+        $this->assertContains('main', $branches);
+        $this->assertContains('test', $branches);
     }
 
     public function testGetLatestCommit(): void