fix: Address bot review feedback (issues 2, 3, 4)

- Add HTTP status checks to createPullRequest and getPullRequest
- Add try/finally blocks to tests for proper cleanup on failures
- Make error test assertions concrete (empty string or exception)
- Improve testGetPullRequestWithInvalidNumber to use try/finally

Note: Issue #1 (adding branch parameter to abstract Git::createFile)
requires architectural decision - will address after maintainer feedback

Author: Your Name

src/VCS/Adapter/Git/Gitea.php

@@ -386,6 +386,12 @@ public function createPullRequest(string $owner, string $repositoryName, string
             $payload
         );
 
+        $responseHeaders = $response['headers'] ?? [];
+        $responseHeadersStatusCode = $responseHeaders['status-code'] ?? 0;
+        if ($responseHeadersStatusCode >= 400) {
+            throw new Exception("Failed to create pull request: HTTP {$responseHeadersStatusCode}");
+        }
+
         $responseBody = $response['body'] ?? [];
 
         return $responseBody;
@@ -448,6 +454,12 @@ public function getPullRequest(string $owner, string $repositoryName, int $pullR
 
         $response = $this->call(self::METHOD_GET, $url, ['Authorization' => "token $this->accessToken"]);
 
+        $responseHeaders = $response['headers'] ?? [];
+        $responseHeadersStatusCode = $responseHeaders['status-code'] ?? 0;
+        if ($responseHeadersStatusCode >= 400) {
+            throw new Exception("Failed to get pull request: HTTP {$responseHeadersStatusCode}");
+        }
+
         return $response['body'] ?? [];
     }
 

tests/VCS/Adapter/GiteaTest.php

@@ -103,45 +103,41 @@ public function testCommentWorkflow(): void
         $repositoryName = 'test-comment-workflow-' . \uniqid();
         $this->vcsAdapter->createRepository(self::$owner, $repositoryName, false);
 
-        $this->vcsAdapter->createFile(self::$owner, $repositoryName, 'README.md', '# Test');
-        $this->vcsAdapter->createBranch(self::$owner, $repositoryName, 'comment-test', 'main');
-        $this->vcsAdapter->createFile(self::$owner, $repositoryName, 'test.txt', 'test', 'Add test file', 'comment-test');
-
-        $pr = $this->vcsAdapter->createPullRequest(
-            self::$owner,
-            $repositoryName,
-            'Comment Test PR',
-            'comment-test',
-            'main'
-        );
-
-        $prNumber = $pr['number'] ?? 0;
-        $this->assertGreaterThan(0, $prNumber);
+        try {
+            $this->vcsAdapter->createFile(self::$owner, $repositoryName, 'README.md', '# Test');
+            $this->vcsAdapter->createBranch(self::$owner, $repositoryName, 'comment-test', 'main');
+            $this->vcsAdapter->createFile(self::$owner, $repositoryName, 'test.txt', 'test', 'Add test file', 'comment-test');
 
-        $originalComment = 'This is a test comment';
-        $commentId = $this->vcsAdapter->createComment(self::$owner, $repositoryName, $prNumber, $originalComment);
+            $pr = $this->vcsAdapter->createPullRequest(
+                self::$owner,
+                $repositoryName,
+                'Comment Test PR',
+                'comment-test',
+                'main'
+            );
 
-        $this->assertNotEmpty($commentId);
-        $this->assertIsString($commentId);
+            $prNumber = $pr['number'] ?? 0;
+            $this->assertGreaterThan(0, $prNumber);
 
-        // Test getComment
-        $retrievedComment = $this->vcsAdapter->getComment(self::$owner, $repositoryName, $commentId);
+            $originalComment = 'This is a test comment';
+            $commentId = $this->vcsAdapter->createComment(self::$owner, $repositoryName, $prNumber, $originalComment);
 
-        $this->assertSame($originalComment, $retrievedComment);
-        $this->assertIsString($commentId);
-        $this->assertNotEmpty($commentId);
+            $this->assertNotEmpty($commentId);
+            $this->assertIsString($commentId);
 
-        // Test updateComment
-        $updatedCommentText = 'This comment has been updated';
-        $updatedCommentId = $this->vcsAdapter->updateComment(self::$owner, $repositoryName, (int)$commentId, $updatedCommentText);
+            $retrievedComment = $this->vcsAdapter->getComment(self::$owner, $repositoryName, $commentId);
+            $this->assertSame($originalComment, $retrievedComment);
 
-        $this->assertSame($commentId, $updatedCommentId);
+            $updatedCommentText = 'This comment has been updated';
+            $updatedCommentId = $this->vcsAdapter->updateComment(self::$owner, $repositoryName, (int)$commentId, $updatedCommentText);
 
-        // Verify the update
-        $finalComment = $this->vcsAdapter->getComment(self::$owner, $repositoryName, $commentId);
-        $this->assertSame($updatedCommentText, $finalComment);
+            $this->assertSame($commentId, $updatedCommentId);
 
-        $this->vcsAdapter->deleteRepository(self::$owner, $repositoryName);
+            $finalComment = $this->vcsAdapter->getComment(self::$owner, $repositoryName, $commentId);
+            $this->assertSame($updatedCommentText, $finalComment);
+        } finally {
+            $this->vcsAdapter->deleteRepository(self::$owner, $repositoryName);
+        }
     }
 
     public function testGetComment(): void
@@ -196,11 +192,10 @@ public function testGetCommentInvalidId(): void
         $this->vcsAdapter->createRepository(self::$owner, $repositoryName, false);
         $this->vcsAdapter->createFile(self::$owner, $repositoryName, 'README.md', '# Test');
 
-        // Getting invalid comment should return empty string
         $result = $this->vcsAdapter->getComment(self::$owner, $repositoryName, '99999999');
 
         $this->assertIsString($result);
-        // May be empty or throw exception depending on API
+        $this->assertSame('', $result);
 
         $this->vcsAdapter->deleteRepository(self::$owner, $repositoryName);
     }
@@ -484,11 +479,12 @@ public function testGetPullRequestWithInvalidNumber(): void
         $this->vcsAdapter->createRepository(self::$owner, $repositoryName, false);
         $this->vcsAdapter->createFile(self::$owner, $repositoryName, 'README.md', '# Test');
 
-        // Try to get non-existent PR
-        $result = $this->vcsAdapter->getPullRequest(self::$owner, $repositoryName, 99999);
-
-        // Should return empty or have error handling
-        $this->assertIsArray($result);
+        try {
+            $this->expectException(\Exception::class);
+            $this->vcsAdapter->getPullRequest(self::$owner, $repositoryName, 99999);
+        } finally {
+            $this->vcsAdapter->deleteRepository(self::$owner, $repositoryName);
+        }
 
         $this->vcsAdapter->deleteRepository(self::$owner, $repositoryName);
     }