fix: remove N-sequential-call loop; GitHub pagination is cursor-only

Author: HarshMN2345

src/VCS/Adapter.php

@@ -233,7 +233,7 @@ abstract public function getRepositoryName(string $repositoryId): string;
      * @param string $owner Owner name of the repository
      * @param string $repositoryName Name of the repository
      * @param int $perPage Number of results per page, clamped to [1, 100]
-     * @param int|string|null $page 1-based integer page number, or an opaque cursor string from a previous nextCursor (cursor form only supported by GitHub)
+     * @param int|string|null $page For GitHub: pass 1 for the first page; for subsequent pages always pass the opaque cursor string from nextCursor — GitHub has no concept of integer offset pages and any integer other than 1 is treated as page 1. For other providers: 1-based integer page number; string cursors are ignored and treated as page 1.
      * @param string $search Prefix filter for branch names; empty string returns all branches
      * @return array{items: array<string>, hasNext: bool, nextCursor: string|null}
      */

src/VCS/Adapter/Git/GitHub.php

@@ -752,40 +752,18 @@ public function getPullRequestFromBranch(string $owner, string $repositoryName,
      * @param  string  $owner
      * @param  string  $repositoryName
      * @param  int  $perPage Clamped to [1, 100]
-     * @param  int|string|null  $page 1-based page number or opaque GraphQL cursor
+     * @param  int|string|null  $page Pass 1 (or null) for the first page. For subsequent pages
+     *   always pass the opaque cursor string from the previous nextCursor — GitHub uses
+     *   cursor-based GraphQL pagination and has no concept of integer page offsets.
+     *   Any integer value other than 1 is treated as page 1.
      * @param  string  $search Prefix filter; empty returns all branches
      * @return array{items: array<string>, hasNext: bool, nextCursor: string|null}
      */
     public function listBranches(string $owner, string $repositoryName, int $perPage = 100, int|string|null $page = 1, string $search = ''): array
     {
         $perPage = min(max($perPage, 1), 100);
         $cursor = is_string($page) ? $page : null;
-        $page = is_int($page) ? max($page, 1) : 1;
-        $result = [
-            'items' => [],
-            'hasNext' => false,
-            'nextCursor' => null,
-        ];
-
-        for ($currentPage = 1; $currentPage <= $page; $currentPage++) {
-            $result = $this->listBranchesPage($owner, $repositoryName, $perPage, $cursor, $search);
-
-            if ($currentPage === $page) {
-                return $result;
-            }
-
-            if ($result['hasNext'] === false) {
-                return [
-                    'items' => [],
-                    'hasNext' => false,
-                    'nextCursor' => null,
-                ];
-            }
-
-            $cursor = $result['nextCursor'];
-        }
-
-        return $result;
+        return $this->listBranchesPage($owner, $repositoryName, $perPage, $cursor, $search);
     }
 
     /**

tests/VCS/Adapter/GitHubTest.php

@@ -546,20 +546,18 @@ public function testListBranchesPagination(): void
             /** @var GitHub $adapter */
             $adapter = $this->vcsAdapter;
 
+            // Cursor-based navigation: always use nextCursor from the previous response
             $page1 = $adapter->listBranches(static::$owner, $repositoryName, 1, 1);
             $this->assertSame(['branch-a'], $page1['items']);
             $this->assertTrue($page1['hasNext']);
             $this->assertNotEmpty($page1['nextCursor']);
 
-            $page2 = $adapter->listBranches(static::$owner, $repositoryName, 1, 2);
+            $page2 = $adapter->listBranches(static::$owner, $repositoryName, 1, $page1['nextCursor']);
             $this->assertSame(['branch-b'], $page2['items']);
             $this->assertTrue($page2['hasNext']);
             $this->assertNotEmpty($page2['nextCursor']);
 
-            $cursorPage2 = $adapter->listBranches(static::$owner, $repositoryName, 1, $page1['nextCursor']);
-            $this->assertSame($page2, $cursorPage2);
-
-            $page3 = $adapter->listBranches(static::$owner, $repositoryName, 1, 3);
+            $page3 = $adapter->listBranches(static::$owner, $repositoryName, 1, $page2['nextCursor']);
             $this->assertSame([static::$defaultBranch], $page3['items']);
             $this->assertFalse($page3['hasNext']);
             $this->assertNull($page3['nextCursor']);