refactor: createCheckRun for initial status only, conclusion via updateCheckRun; add actions param

Author: HarshMN2345

src/VCS/Adapter.php

@@ -237,11 +237,12 @@ abstract public function updateCommitStatus(string $repositoryName, string $SHA,
 
     /**
      * Creates a check run for a commit.
-     * status can be one of: queued, in_progress, completed
-     * conclusion (required when status=completed) can be one of: action_required, cancelled, failure, neutral, success, skipped, timed_out
+     * status can be one of: queued, in_progress
+     * Use updateCheckRun() to set conclusion and mark the run as completed.
      *
      * @param array<mixed> $annotations
      * @param array<mixed> $images
+     * @param array<mixed> $actions
      * @return array<mixed>
      */
     public function createCheckRun(
@@ -250,16 +251,15 @@ public function createCheckRun(
         string $headSha,
         string $name,
         string $status = 'queued',
-        string $conclusion = '',
         string $title = '',
         string $summary = '',
         string $text = '',
         array $annotations = [],
         array $images = [],
+        array $actions = [],
         string $detailsUrl = '',
         string $externalId = '',
         string $startedAt = '',
-        string $completedAt = '',
     ): array {
         throw new \Exception('createCheckRun() is not implemented for ' . $this->getName());
     }
@@ -281,6 +281,7 @@ public function getCheckRun(string $owner, string $repositoryName, int $checkRun
      *
      * @param array<mixed> $annotations
      * @param array<mixed> $images
+     * @param array<mixed> $actions
      * @return array<mixed>
      */
     public function updateCheckRun(
@@ -295,6 +296,7 @@ public function updateCheckRun(
         string $text = '',
         array $annotations = [],
         array $images = [],
+        array $actions = [],
         string $detailsUrl = '',
         string $externalId = '',
         string $startedAt = '',

src/VCS/Adapter/Git/GitHub.php

@@ -874,11 +874,12 @@ public function updateCommitStatus(string $repositoryName, string $commitHash, s
 
     /**
      * Creates a check run for a commit.
-     * status can be one of: queued, in_progress, completed
-     * conclusion (required when status=completed) can be one of: action_required, cancelled, failure, neutral, success, skipped, timed_out
+     * status can be one of: queued, in_progress
+     * Use updateCheckRun() to set conclusion and mark the run as completed.
      *
      * @param array<mixed> $annotations
      * @param array<mixed> $images
+     * @param array<mixed> $actions
      * @return array<mixed>
      */
     public function createCheckRun(
@@ -887,27 +888,18 @@ public function createCheckRun(
         string $headSha,
         string $name,
         string $status = 'queued',
-        string $conclusion = '',
         string $title = '',
         string $summary = '',
         string $text = '',
         array $annotations = [],
         array $images = [],
+        array $actions = [],
         string $detailsUrl = '',
         string $externalId = '',
         string $startedAt = '',
-        string $completedAt = '',
     ): array {
         $url = "/repos/$owner/$repositoryName/check-runs";
 
-        // Conclusion requires status=completed; auto-set completed_at if not provided.
-        if (!empty($conclusion)) {
-            $status = 'completed';
-            if (empty($completedAt)) {
-                $completedAt = gmdate('Y-m-d\TH:i:s\Z');
-            }
-        }
-
         $body = array_merge(
             [
                 'name' => $name,
@@ -918,8 +910,6 @@ public function createCheckRun(
                 'details_url' => $detailsUrl,
                 'external_id' => $externalId,
                 'started_at' => $startedAt,
-                'conclusion' => $conclusion,
-                'completed_at' => $completedAt,
             ], fn ($value) => !empty($value))
         );
 
@@ -935,6 +925,10 @@ public function createCheckRun(
             $body['output'] = $output;
         }
 
+        if (!empty($actions)) {
+            $body['actions'] = $actions;
+        }
+
         $response = $this->call(self::METHOD_POST, $url, ['Authorization' => "Bearer $this->accessToken"], $body);
 
         return $response['body'] ?? [];
@@ -975,6 +969,7 @@ public function updateCheckRun(
         string $text = '',
         array $annotations = [],
         array $images = [],
+        array $actions = [],
         string $detailsUrl = '',
         string $externalId = '',
         string $startedAt = '',
@@ -1012,6 +1007,10 @@ public function updateCheckRun(
             $body['output'] = $output;
         }
 
+        if (!empty($actions)) {
+            $body['actions'] = $actions;
+        }
+
         $response = $this->call(self::METHOD_PATCH, $url, ['Authorization' => "Bearer $this->accessToken"], $body);
 
         return $response['body'] ?? [];

tests/VCS/Adapter/GitHubTest.php

@@ -664,22 +664,17 @@ public function testCreateCheckRun(): void
                 repositoryName: $repositoryName,
                 headSha: $commitHash,
                 name: 'ci/build',
-                status: 'completed',
-                conclusion: 'neutral',
-                title: 'Deployment skipped',
-                summary: 'Deployment skipped because the commit message contains a skip pattern.',
-                completedAt: gmdate('Y-m-d\TH:i:s\Z'),
+                status: 'in_progress',
+                startedAt: gmdate('Y-m-d\TH:i:s\Z'),
             );
 
             $this->assertArrayHasKey('id', $checkRun);
-            $this->assertEquals('completed', $checkRun['status']);
-            $this->assertEquals('neutral', $checkRun['conclusion']);
+            $this->assertEquals('in_progress', $checkRun['status']);
             $this->assertEquals('ci/build', $checkRun['name']);
 
             $fetched = $this->vcsAdapter->getCheckRun(static::$owner, $repositoryName, $checkRun['id']);
             $this->assertEquals($checkRun['id'], $fetched['id']);
-            $this->assertEquals('neutral', $fetched['conclusion']);
-            $this->assertEquals('completed', $fetched['status']);
+            $this->assertEquals('in_progress', $fetched['status']);
         } finally {
             $this->vcsAdapter->deleteRepository(static::$owner, $repositoryName);
         }