Skip to content

Set author email when parsing push events #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Meldiron merged 2 commits into from
Jul 23, 2025
Merged

Set author email when parsing push events #45

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62392d8
Set author email when parsing push events
hmacr Jul 22, 2025
414583f
change author name field
hmacr Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/VCS/Adapter/Git/GitHub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,6 +602,7 @@ public function getEvent(string $event, string $payload): array
$authorUrl = $payload['sender']['html_url'];
$authorAvatarUrl = $payload['sender']['avatar_url'] ?? '';
$headCommitAuthor = $payload['head_commit']['author']['name'] ?? '';
$headCommitAuthorEmail = $payload['head_commit']['author']['email'] ?? '';
$headCommitMessage = $payload['head_commit']['message'] ?? '';
$headCommitUrl = $payload['head_commit']['url'] ?? '';

Expand All @@ -619,6 +620,7 @@ public function getEvent(string $event, string $payload): array
'authorUrl' => $authorUrl,
'authorAvatarUrl' => $authorAvatarUrl,
'headCommitAuthor' => $headCommitAuthor,
Copy link
Copy Markdown
Contributor

@Meldiron Meldiron Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a breaking change, so it will require update in Appwrite's usage of library, but let's please rename this variable to headCommitAuthorName, to be consistent with newly added headCommitAuthorEmail.

Copy link
Copy Markdown
Contributor Author

@hmacr hmacr Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree on consistency - I was worried about backward compatibility.. if we can ensure compat, I'm down 👍

'headCommitAuthorEmail' => $headCommitAuthorEmail,
'headCommitMessage' => $headCommitMessage,
'headCommitUrl' => $headCommitUrl,
'external' => false,
Expand Down