Conversation
…, createFile for GitLab adapter
81676d3 to
d8036b8
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Greptile SummaryThis PR adds Confidence Score: 5/5Safe to merge; all remaining findings are P2 suggestions with no blocking defects. Both previously flagged issues are addressed. The implementation closely mirrors the existing GitHub adapter. The only open finding is a test coverage gap (tag/commit clone paths are not executed end-to-end), which is a P2 improvement rather than a correctness problem. tests/VCS/Adapter/GitLabTest.php — consider adding exec-based assertions for tag and commit-hash clone tests.
|
| Filename | Overview |
|---|---|
| src/VCS/Adapter/Git/GitLab.php | Adds generateCloneCommand, getLatestCommit, getCommit, createTag, and createFile; fixes shell injection in CLONE_TYPE_TAG by using escapeshellarg result, and switches commits API to per_page=1. Logic mirrors the GitHub adapter closely. |
| tests/VCS/Adapter/GitLabTest.php | Adds integration tests for all new methods; branch clone is fully executed end-to-end, but tag and commit-hash clone tests only validate the command string without executing it. |
Reviews (2): Last reviewed commit: "fix: shell injection in CLONE_TYPE_TAG a..." | Re-trigger Greptile
No description provided.