fix(cardano): correct getWalletsByTag URL path and encode tag#128
Merged
Conversation
The endpoint was hitting `api/project-wallet/{projectId}/cardano/tag/{tag}`,
which does not exist on the server — the route is
`api/project-wallet/{projectId}/tag/{tagstring}`. Every call returned 404
HTML even when matching wallets existed.
Also URL-encode the tag so emails and any tag with special characters
(`@`, `/`, spaces, etc.) round-trip safely through the path segment.
Bumped version to 0.2.3.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getWalletsByTagwas callingapi/project-wallet/{projectId}/cardano/tag/{tag}, which does not exist on the server. The actual route isapi/project-wallet/{projectId}/tag/{tagstring}(seeapps/app/src/pages/api/project-wallet/[projectId]/tag/[tagstring].ts). Every call returned a 404 HTML page even when matching wallets existed.@,/, spaces, or other special characters round-trip safely through the path segment.0.2.3.Repro (before patch)
After patch
Verified end-to-end against
https://utxos.devwith 5 random wallet tags from a real 379-wallet project — every call returned the expectedMultiChainWalletInfo[]with matchingidandtags.Test plan
sdk.wallet.cardano.getWalletsByTag(email)returns matching wallets on mainnet@work (email tags)🤖 Generated with Claude Code