coreutils: --list arg and no args should fail

Author: oech3

src/bin/coreutils.rs

@@ -8,7 +8,7 @@ use coreutils::validation;
 use itertools::Itertools as _;
 use std::cmp;
 use std::ffi::OsString;
-use std::io::{self, Write};
+use std::io::{self, Write, stderr};
 use std::process;
 use uucore::Args;
 
@@ -76,19 +76,18 @@ fn main() {
 
         match util {
             "--list" => {
-                // If --help is also present, show usage instead of list
-                if args.any(|arg| arg == "--help" || arg == "-h") {
-                    usage(&utils, binary_as_util);
-                    process::exit(0);
+                // GNU does not like lax options https://github.com/uutils/coreutils/issues/11383#issuecomment-4082564058
+                if args.next().is_some() {
+                    let _ = writeln!(stderr(), "coreutils: invalid sub-command");
+                    process::exit(1);
                 }
-                let utils: Vec<_> = utils.keys().collect();
-                for util in utils {
+                for util in utils.keys() {
                     println!("{util}");
                 }
                 process::exit(0);
             }
             "--version" | "-V" => {
-                println!("{binary_as_util} {VERSION} (multi-call binary)");
+                println!("coreutils {VERSION} (multi-call binary)");
                 process::exit(0);
             }
             // Not a special command: fallthrough to calling a util
@@ -138,7 +137,9 @@ fn main() {
         }
     } else {
         // no arguments provided
-        usage(&utils, binary_as_util);
-        process::exit(0);
+        let _ = writeln!(stderr(), "coreutils: missing argument");
+        // GNU exit(1), but busybox tests needs exit(0)
+        // todo: patch the test suite instead.
+        process::exit(!binary_as_util.ends_with("box") as i32);
     }
 }