feat(sort): add warning messages for obsolescent keys and options (#9900)

* feat(sort): add warning messages for obsolescent keys and options

Added localized warning messages in en-US.ftl for various sort command issues, including obsolescent key formats, ignored options, and locale-related warnings. Implemented LegacyKeyWarning struct and GlobalOptionFlags in sort.rs to detect deprecated key syntax (e.g., +field -field) and suggest modern -k replacements, improving user guidance and compatibility.

* refactor(sort): remove stable and unique flags from GlobalOptionFlags

Removes the unused `stable` and `unique` boolean fields from the GlobalOptionFlags struct and their initialization in the impl block, simplifying the code by eliminating redundant options.

* feat(sort): allow multiple sort modes by removing mutual conflicts

Previously, sort mode flags were mutually exclusive, preventing users from specifying more than one mode. This change removes the conflicts to enable combining sort options for more flexible sorting behavior.

* refactor(sort): separate arg_index and key_index in legacy key warnings

- Update LegacyKeyWarning struct to include arg_index and make key_index optional
- Modify preprocess_legacy_args to set arg_index instead of key_index during parsing
- Add index_legacy_warnings function to compute key_index after arg processing
- Adjust emit_debug_warnings to match updated key_index type
- This ensures accurate indexing for legacy key warnings in sort utility

* feat(sort): add legacy sort key detection for '+' prefixed arguments

- Introduce `starts_with_plus` function to check for arguments starting with '+' in a platform-specific manner
- Modify `parse_sort_arguments` to detect and process legacy sort keys, enabling proper handling of deprecated options with warnings
- This ensures backward compatibility for users relying on old sort syntax while guiding migration to modern flags

* refactor(sort): simplify legacy args preprocessing

Remove intermediate vector creation in preprocess_legacy_args and streamline the handling of legacy '+' prefixed arguments to improve efficiency and readability without altering functionality. Additionally, refactor uumain to directly index legacy warnings when present.

* refactor(sort/benches): optimize locale UTF8 benchmarks by predefining args

Move output file creation and argument setup outside benchmark loops in sort_locale_utf8_bench.rs to avoid measuring initialization time in each iteration, ensuring accurate performance measurements for sorting operations.

---------

Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>

Author: mattsu2020

src/uu/sort/benches/sort_locale_utf8_bench.rs

@@ -21,11 +21,10 @@ fn sort_ascii_utf8_locale(bencher: Bencher) {
     let output_file = NamedTempFile::new().unwrap();
     let output_path = output_file.path().to_str().unwrap().to_string();
 
+    let args = ["-o", &output_path, file_path.to_str().unwrap()];
+    black_box(run_util_function(uumain, &args));
     bencher.bench(|| {
-        black_box(run_util_function(
-            uumain,
-            &["-o", &output_path, file_path.to_str().unwrap()],
-        ));
+        black_box(run_util_function(uumain, &args));
     });
 }
 
@@ -37,11 +36,10 @@ fn sort_mixed_utf8_locale(bencher: Bencher) {
     let output_file = NamedTempFile::new().unwrap();
     let output_path = output_file.path().to_str().unwrap().to_string();
 
+    let args = ["-o", &output_path, file_path.to_str().unwrap()];
+    black_box(run_util_function(uumain, &args));
     bencher.bench(|| {
-        black_box(run_util_function(
-            uumain,
-            &["-o", &output_path, file_path.to_str().unwrap()],
-        ));
+        black_box(run_util_function(uumain, &args));
     });
 }
 
@@ -54,12 +52,13 @@ fn sort_numeric_utf8_locale(bencher: Bencher) {
         data.extend_from_slice(line.as_bytes());
     }
     let file_path = setup_test_file(&data);
+    let output_file = NamedTempFile::new().unwrap();
+    let output_path = output_file.path().to_str().unwrap().to_string();
 
+    let args = ["-n", "-o", &output_path, file_path.to_str().unwrap()];
+    black_box(run_util_function(uumain, &args));
     bencher.bench(|| {
-        black_box(run_util_function(
-            uumain,
-            &["-n", file_path.to_str().unwrap()],
-        ));
+        black_box(run_util_function(uumain, &args));
     });
 }
 
@@ -68,12 +67,13 @@ fn sort_numeric_utf8_locale(bencher: Bencher) {
 fn sort_reverse_utf8_locale(bencher: Bencher) {
     let data = text_data::generate_mixed_locale_data(50_000);
     let file_path = setup_test_file(&data);
+    let output_file = NamedTempFile::new().unwrap();
+    let output_path = output_file.path().to_str().unwrap().to_string();
 
+    let args = ["-r", "-o", &output_path, file_path.to_str().unwrap()];
+    black_box(run_util_function(uumain, &args));
     bencher.bench(|| {
-        black_box(run_util_function(
-            uumain,
-            &["-r", file_path.to_str().unwrap()],
-        ));
+        black_box(run_util_function(uumain, &args));
     });
 }
 
@@ -82,12 +82,13 @@ fn sort_reverse_utf8_locale(bencher: Bencher) {
 fn sort_unique_utf8_locale(bencher: Bencher) {
     let data = text_data::generate_mixed_locale_data(50_000);
     let file_path = setup_test_file(&data);
+    let output_file = NamedTempFile::new().unwrap();
+    let output_path = output_file.path().to_str().unwrap().to_string();
 
+    let args = ["-u", "-o", &output_path, file_path.to_str().unwrap()];
+    black_box(run_util_function(uumain, &args));
     bencher.bench(|| {
-        black_box(run_util_function(
-            uumain,
-            &["-u", file_path.to_str().unwrap()],
-        ));
+        black_box(run_util_function(uumain, &args));
     });
 }
 

src/uu/sort/locales/en-US.ftl

@@ -51,6 +51,22 @@ sort-error-write-failed = write failed: {$output}
 sort-failed-to-delete-temporary-directory = failed to delete temporary directory: {$error}
 sort-failed-to-set-up-signal-handler = failed to set up signal handler: {$error}
 
+# Warning messages
+sort-warning-failed-to-set-locale = failed to set locale
+sort-warning-simple-byte-comparison = text ordering performed using simple byte comparison
+sort-warning-key-zero-width = key {$key} has zero width and will be ignored
+sort-warning-key-numeric-spans-fields = key {$key} is numeric and spans multiple fields
+sort-warning-leading-blanks-significant = leading blanks are significant in key {$key}; consider also specifying 'b'
+sort-warning-numbers-use-decimal-point = numbers use '.' as a decimal point in this locale
+sort-warning-options-ignored = options '-{$options}' are ignored
+sort-warning-option-ignored = option '-{$option}' is ignored
+sort-warning-option-reverse-last-resort = option '-r' only applies to last-resort comparison
+sort-warning-obsolescent-key = obsolescent key '{$key}' used; consider '-k {$replacement}' instead
+sort-warning-separator-grouping = field separator '{$sep}' is treated as a group separator in numbers
+sort-warning-separator-decimal = field separator '{$sep}' is treated as a decimal point in numbers
+sort-warning-separator-minus = field separator '{$sep}' is treated as a minus sign in numbers
+sort-warning-separator-plus = field separator '{$sep}' is treated as a plus sign in numbers
+
 # Help messages
 sort-help-help = Print help information.
 sort-help-version = Print version information.