uucore: introduce IS_POSIXLY_CORRECT static

Author: xtqqczze

src/uu/df/src/blocks.rs

@@ -199,9 +199,6 @@ impl fmt::Display for BlockSize {
 
 #[cfg(test)]
 mod tests {
-
-    use std::env;
-
     use crate::blocks::{BlockSize, SuffixType, to_magnitude_and_suffix};
 
     #[test]
@@ -367,12 +364,4 @@ mod tests {
         assert_eq!(format!("{}", BlockSize::Bytes(1000 * 1024)), "1.1MB");
         assert_eq!(format!("{}", BlockSize::Bytes(1_000_000_000_000)), "1.0TB");
     }
-
-    #[test]
-    fn test_default_block_size() {
-        assert_eq!(BlockSize::Bytes(1024), BlockSize::default());
-        unsafe { env::set_var("POSIXLY_CORRECT", "1") };
-        assert_eq!(BlockSize::Bytes(512), BlockSize::default());
-        unsafe { env::remove_var("POSIXLY_CORRECT") };
-    }
 }

src/uucore/src/lib/features/parser/parse_block_size.rs

@@ -9,6 +9,8 @@
 //! for resolving block sizes from environment variables and defaults.
 //! This module centralizes that logic.
 
+use std::sync::LazyLock;
+
 use super::parse_size::parse_size_non_zero_u64;
 
 /// Result of looking up a block size from environment variables.
@@ -66,13 +68,12 @@ pub fn block_size_from_env(vars: &[&str]) -> BlockSizeEnv {
 ///
 /// Returns 512 if `POSIXLY_CORRECT` is set, 1024 otherwise.
 pub fn default_block_size() -> u64 {
-    if std::env::var("POSIXLY_CORRECT").is_ok() {
-        512
-    } else {
-        1024
-    }
+    if *IS_POSIXLY_CORRECT { 512 } else { 1024 }
 }
 
+static IS_POSIXLY_CORRECT: LazyLock<bool> =
+    LazyLock::new(|| std::env::var_os("POSIXLY_CORRECT").is_some());
+
 #[cfg(test)]
 mod tests {
     use super::*;
@@ -344,34 +345,4 @@ mod tests {
 
         clear_env_vars(&["BLOCKSIZE"]);
     }
-
-    #[test]
-    fn test_default_block_size_without_posixly_correct() {
-        let _guard = ENV_LOCK.lock().unwrap();
-        clear_env_vars(&["POSIXLY_CORRECT"]);
-        assert_eq!(default_block_size(), 1024);
-    }
-
-    #[test]
-    fn test_default_block_size_with_posixly_correct() {
-        let _guard = ENV_LOCK.lock().unwrap();
-        clear_env_vars(&["POSIXLY_CORRECT"]);
-
-        set_env_var("POSIXLY_CORRECT", "1");
-        assert_eq!(default_block_size(), 512);
-
-        clear_env_vars(&["POSIXLY_CORRECT"]);
-    }
-
-    #[test]
-    fn test_default_block_size_with_posixly_correct_empty() {
-        let _guard = ENV_LOCK.lock().unwrap();
-        clear_env_vars(&["POSIXLY_CORRECT"]);
-
-        // Even an empty value means POSIXLY_CORRECT is set
-        set_env_var("POSIXLY_CORRECT", "");
-        assert_eq!(default_block_size(), 512);
-
-        clear_env_vars(&["POSIXLY_CORRECT"]);
-    }
 }