Annotate more WASI-incompatible tests caught on Linux

Author: DePasqualeOrg

docs/src/wasi-test-gaps.md

@@ -68,6 +68,14 @@ The test harness maps the per-test working directory as the guest's `/`. That ma
 
 On WASI, `touch -` returns `UnsupportedPlatformFeature` because the guest cannot reliably locate the host file backing stdout. Tests that exercise `touch -` are skipped.
 
+## WASI: rlimit/setrlimit not supported
+
+WASI has no concept of per-process resource limits, so `setrlimit` (and the `rlimit` crate that wraps it) has no effect. Tests that set `RLIMIT_NOFILE` to verify behaviour under restricted file-descriptor budgets are skipped.
+
+## WASI: sysinfo/meminfo not available
+
+WASI has no `sysinfo`/`/proc/meminfo` equivalent, so features that size buffers as a percentage of system memory (e.g. `sort -S 10%`) cannot resolve the limit and fail. Tests that exercise percentage-based sizing are skipped.
+
 ## WASI: errno/error-message mismatches
 
 Several error paths surface different errno values (and therefore different error messages) through wasmtime than on POSIX. Observed cases:

tests/by-util/test_cat.rs

@@ -131,6 +131,7 @@ fn test_fifo_symlink() {
 // TODO(#7542): Re-enable on Android once we figure out why setting limit is broken.
 // #[cfg(any(target_os = "linux", target_os = "android"))]
 #[cfg(target_os = "linux")]
+#[cfg_attr(wasi_runner, ignore = "WASI: rlimit/setrlimit not supported")]
 fn test_closes_file_descriptors() {
     // Each file creates a pipe, which has two file descriptors.
     // If they are not closed then five is certainly too many.
@@ -556,6 +557,7 @@ fn test_dev_random() {
 /// Wikipedia says there is support on Linux, FreeBSD, and `NetBSD`.
 #[test]
 #[cfg(any(target_os = "linux", target_os = "freebsd", target_os = "netbsd"))]
+#[cfg_attr(wasi_runner, ignore = "WASI sandbox: host paths not visible")]
 fn test_dev_full() {
     let mut proc = new_ucmd!()
         .set_stdout(Stdio::piped())
@@ -571,6 +573,7 @@ fn test_dev_full() {
 
 #[test]
 #[cfg(any(target_os = "linux", target_os = "freebsd", target_os = "netbsd"))]
+#[cfg_attr(wasi_runner, ignore = "WASI sandbox: host paths not visible")]
 fn test_dev_full_show_all() {
     let buf_len = 2048;
     let mut proc = new_ucmd!()
@@ -593,6 +596,7 @@ fn test_dev_full_show_all() {
 // without additional flush output gets reversed.
 #[test]
 #[cfg(target_os = "linux")]
+#[cfg_attr(wasi_runner, ignore = "WASI sandbox: host paths not visible")]
 fn test_write_fast_fallthrough_uses_flush() {
     const PROC_INIT_CMDLINE: &str = "/proc/1/cmdline";
     let cmdline = read_to_string(PROC_INIT_CMDLINE).unwrap();
@@ -746,6 +750,7 @@ fn test_u_ignored() {
 
 #[test]
 #[cfg(unix)]
+#[cfg_attr(wasi_runner, ignore = "WASI: errno/error-message mismatches")]
 fn test_write_fast_read_error() {
     use std::os::unix::fs::PermissionsExt;
 
@@ -766,6 +771,7 @@ fn test_write_fast_read_error() {
 
 #[test]
 #[cfg(target_os = "linux")]
+#[cfg_attr(wasi_runner, ignore = "WASI: argv/filenames must be valid UTF-8")]
 fn test_cat_non_utf8_paths() {
     use std::ffi::OsStr;
     use std::os::unix::ffi::OsStrExt;
@@ -790,6 +796,7 @@ fn test_cat_non_utf8_paths() {
 
 #[test]
 #[cfg(target_os = "linux")]
+#[cfg_attr(wasi_runner, ignore = "WASI: cannot detect unsafe overwrite")]
 fn test_appending_same_input_output() {
     let (at, mut ucmd) = at_and_ucmd!();
 

tests/by-util/test_comm.rs

@@ -450,6 +450,7 @@ fn test_is_dir() {
 }
 
 #[test]
+#[cfg_attr(wasi_runner, ignore = "WASI: no locale data")]
 fn test_sorted() {
     let scene = TestScenario::new(util_name!());
     let at = &scene.fixtures;
@@ -486,6 +487,7 @@ fn test_sorted_check_order() {
 }
 
 #[test]
+#[cfg_attr(wasi_runner, ignore = "WASI: no locale data")]
 fn test_both_inputs_out_of_order() {
     let scene = TestScenario::new(util_name!());
     let at = &scene.fixtures;
@@ -508,6 +510,7 @@ fn test_both_inputs_out_of_order() {
 }
 
 #[test]
+#[cfg_attr(wasi_runner, ignore = "WASI: no locale data")]
 fn test_both_inputs_out_of_order_last_pair() {
     let scene = TestScenario::new(util_name!());
     let at = &scene.fixtures;

tests/by-util/test_sort.rs

@@ -36,6 +36,7 @@ fn test_helper(file_name: &str, possible_args: &[&str]) {
 }
 
 #[test]
+#[cfg_attr(wasi_runner, ignore = "WASI: sysinfo/meminfo not available")]
 fn test_buffer_sizes() {
     #[cfg(target_os = "linux")]
     let buffer_sizes = ["0", "50K", "50k", "1M", "100M", "0%", "10%"];
@@ -1289,6 +1290,7 @@ fn sort_empty_chunk() {
 
 #[test]
 #[cfg(any(target_os = "linux", target_os = "android"))]
+#[cfg_attr(wasi_runner, ignore = "WASI: no subprocess spawning")]
 fn test_compress() {
     new_ucmd!()
         .args(&[
@@ -1305,6 +1307,7 @@ fn test_compress() {
 
 #[test]
 #[cfg(any(target_os = "linux", target_os = "android"))]
+#[cfg_attr(wasi_runner, ignore = "WASI: no subprocess spawning")]
 fn test_compress_merge() {
     new_ucmd!()
         .args(&[
@@ -1382,6 +1385,7 @@ fn test_batch_size_invalid() {
 }
 
 #[test]
+#[cfg_attr(wasi_runner, ignore = "WASI: rlimit/setrlimit not supported")]
 fn test_batch_size_too_large() {
     let large_batch_size = "18446744073709551616";
     new_ucmd!()
@@ -1418,6 +1422,7 @@ fn test_merge_batch_size() {
 // TODO(#7542): Re-enable on Android once we figure out why setting limit is broken.
 // #[cfg(any(target_os = "linux", target_os = "android"))]
 #[cfg(target_os = "linux")]
+#[cfg_attr(wasi_runner, ignore = "WASI: rlimit/setrlimit not supported")]
 fn test_merge_batch_size_with_limit() {
     use rlimit::Resource;
     // Currently need...
@@ -1782,6 +1787,7 @@ fn test_files0_read_error() {
 
 #[cfg(target_os = "linux")]
 #[test]
+#[cfg_attr(wasi_runner, ignore = "WASI sandbox: host paths not visible")]
 // Test for GNU tests/sort/sort-files0-from.pl "empty-non-regular"
 fn test_files0_from_empty_non_regular() {
     new_ucmd!()
@@ -2948,6 +2954,7 @@ fn test_locale_utf8_sort_debug_message() {
 
 #[test]
 #[cfg(unix)]
+#[cfg_attr(wasi_runner, ignore = "WASI: no locale data")]
 fn test_failed_to_set_locale_debug_message() {
     let result = new_ucmd!()
         .env("LC_ALL", "not-valid-locale")

tests/by-util/test_tail.rs

@@ -259,6 +259,7 @@ fn test_n0_with_follow() {
 // TODO: Add similar test for windows
 #[test]
 #[cfg(unix)]
+#[cfg_attr(wasi_runner, ignore = "WASI: errno/error-message mismatches")]
 fn test_permission_denied() {
     use std::os::unix::fs::PermissionsExt;
 
@@ -279,6 +280,7 @@ fn test_permission_denied() {
 // TODO: Add similar test for windows
 #[test]
 #[cfg(unix)]
+#[cfg_attr(wasi_runner, ignore = "WASI: errno/error-message mismatches")]
 fn test_permission_denied_multiple() {
     use std::os::unix::fs::PermissionsExt;
 
@@ -327,6 +329,7 @@ fn test_follow_redirect_stdin_name_retry() {
     not(target_os = "freebsd"),
     not(target_os = "openbsd")
 ))] // FIXME: for currently not working platforms
+#[cfg_attr(wasi_runner, ignore = "WASI: errno/error-message mismatches")]
 fn test_stdin_redirect_dir() {
     // $ mkdir dir
     // $ tail < dir, $ tail - < dir
@@ -765,6 +768,7 @@ fn test_follow_invalid_pid() {
     not(target_os = "android"),
     not(target_os = "freebsd")
 ))] // FIXME: for currently not working platforms
+#[cfg_attr(wasi_runner, ignore = "WASI: tail follow mode disabled")]
 fn test_follow_with_pid() {
     use std::process::Command;
 
@@ -1314,6 +1318,7 @@ fn test_num_with_undocumented_sign_bytes() {
 
 #[test]
 #[cfg(unix)]
+#[cfg_attr(wasi_runner, ignore = "WASI sandbox: host paths not visible")]
 fn test_bytes_for_funny_unix_files() {
     // inspired by: gnu/tests/tail-2/tail-c.sh
     let ts = TestScenario::new(util_name!());
@@ -1375,6 +1380,7 @@ fn test_retry2() {
     not(target_os = "freebsd"),
     not(target_os = "openbsd")
 ))] // FIXME: for currently not working platforms
+#[cfg_attr(wasi_runner, ignore = "WASI: tail follow mode disabled")]
 fn test_retry3() {
     // inspired by: gnu/tests/tail-2/retry.sh
     // Ensure that `tail --retry --follow=name` waits for the file to appear.
@@ -1420,6 +1426,7 @@ fn test_retry3() {
     not(target_os = "freebsd"),
     not(target_os = "openbsd")
 ))] // FIXME: for currently not working platforms
+#[cfg_attr(wasi_runner, ignore = "WASI: tail follow mode disabled")]
 fn test_retry4() {
     // inspired by: gnu/tests/tail-2/retry.sh
     // Ensure that `tail --retry --follow=descriptor` waits for the file to appear.
@@ -1478,6 +1485,7 @@ fn test_retry4() {
     not(target_os = "freebsd"),
     not(target_os = "openbsd")
 ))] // FIXME: for currently not working platforms
+#[cfg_attr(wasi_runner, ignore = "WASI: tail follow mode disabled")]
 fn test_retry5() {
     // inspired by: gnu/tests/tail-2/retry.sh
     // Ensure that `tail --follow=descriptor --retry` exits when the file appears untailable.
@@ -1569,6 +1577,7 @@ fn test_retry6() {
     not(target_os = "freebsd"),
     not(target_os = "openbsd")
 ))] // FIXME: for currently not working platforms
+#[cfg_attr(wasi_runner, ignore = "WASI: tail follow mode disabled")]
 fn test_retry7() {
     // inspired by: gnu/tests/tail-2/retry.sh
     // Ensure that `tail -F` retries when the file is initially untailable.
@@ -1644,6 +1653,7 @@ fn test_retry7() {
     not(target_os = "freebsd"),
     not(target_os = "openbsd")
 ))] // FIXME: for currently not working platforms
+#[cfg_attr(wasi_runner, ignore = "WASI: tail follow mode disabled")]
 fn test_retry8() {
     // Ensure that inotify will switch to polling mode if directory
     // of the watched file was initially missing and later created.
@@ -1713,6 +1723,7 @@ fn test_retry8() {
     not(target_os = "freebsd"),
     not(target_os = "openbsd")
 ))] // FIXME: for currently not working platforms
+#[cfg_attr(wasi_runner, ignore = "WASI: tail follow mode disabled")]
 fn test_retry9() {
     // inspired by: gnu/tests/tail-2/inotify-dir-recreate.sh
     // Ensure that inotify will switch to polling mode if directory
@@ -1795,6 +1806,7 @@ fn test_retry9() {
     not(target_os = "freebsd"),
     not(target_os = "openbsd")
 ))] // FIXME: for currently not working platforms
+#[cfg_attr(wasi_runner, ignore = "WASI: tail follow mode disabled")]
 fn test_follow_descriptor_vs_rename1() {
     // inspired by: gnu/tests/tail-2/descriptor-vs-rename.sh
     // $ ((rm -f A && touch A && sleep 1 && echo -n "A\n" >> A && sleep 1 && \
@@ -1859,6 +1871,7 @@ fn test_follow_descriptor_vs_rename1() {
     not(target_os = "freebsd"),
     not(target_os = "openbsd")
 ))] // FIXME: for currently not working platforms
+#[cfg_attr(wasi_runner, ignore = "WASI: tail follow mode disabled")]
 fn test_follow_descriptor_vs_rename2() {
     // Ensure the headers are correct for --verbose.
     // NOTE: GNU's tail does not update the header from FILE_A to FILE_C after `mv FILE_A FILE_C`
@@ -1912,6 +1925,7 @@ fn test_follow_descriptor_vs_rename2() {
     not(target_os = "freebsd"),
     not(target_os = "openbsd")
 ))] // FIXME: for currently not working platforms
+#[cfg_attr(wasi_runner, ignore = "WASI: tail follow mode disabled")]
 fn test_follow_name_retry_headers() {
     // inspired by: "gnu/tests/tail-2/F-headers.sh"
     // Ensure tail -F distinguishes output with the
@@ -2166,6 +2180,7 @@ fn test_follow_name_truncate3() {
     not(target_os = "windows"),
     not(feature = "feat_selinux") // flaky
 ))] // FIXME: for currently not working platforms
+#[cfg_attr(wasi_runner, ignore = "WASI: tail follow mode disabled")]
 fn test_follow_name_truncate4() {
     // Truncating a file with the same content it already has should not trigger a truncate event
 
@@ -2256,6 +2271,7 @@ fn test_follow_truncate_fast() {
     not(target_os = "freebsd"),
     not(target_os = "openbsd")
 ))] // FIXME: for currently not working platforms
+#[cfg_attr(wasi_runner, ignore = "WASI: tail follow mode disabled")]
 fn test_follow_name_move_create1() {
     // This test triggers a move/create event while `tail --follow=name file` is running.
     // ((sleep 2 && mv file backup && sleep 2 && cp backup file &)>/dev/null 2>&1 &) ; tail --follow=name file
@@ -2312,6 +2328,7 @@ fn test_follow_name_move_create1() {
     not(target_os = "freebsd"),
     not(target_os = "openbsd")
 ))] // FIXME: for currently not working platforms
+#[cfg_attr(wasi_runner, ignore = "WASI: tail follow mode disabled")]
 fn test_follow_name_move_create2() {
     // inspired by: "gnu/tests/tail-2/inotify-hash-abuse.sh"
     // Exercise an abort-inducing flaw in inotify-enabled tail -F
@@ -2392,6 +2409,7 @@ fn test_follow_name_move_create2() {
     not(target_os = "freebsd"),
     not(target_os = "openbsd")
 ))] // FIXME: for currently not working platforms
+#[cfg_attr(wasi_runner, ignore = "WASI: tail follow mode disabled")]
 fn test_follow_name_move1() {
     // This test triggers a move event while `tail --follow=name file` is running.
     // ((sleep 2 && mv file backup &)>/dev/null 2>&1 &) ; tail --follow=name file
@@ -2454,6 +2472,7 @@ fn test_follow_name_move1() {
     not(target_os = "freebsd"),
     not(target_os = "openbsd")
 ))] // FIXME: for currently not working platforms
+#[cfg_attr(wasi_runner, ignore = "WASI: tail follow mode disabled")]
 fn test_follow_name_move2() {
     // Like test_follow_name_move1, but move to a name that's already monitored.
 
@@ -2542,6 +2561,7 @@ fn test_follow_name_move2() {
     not(target_os = "freebsd"),
     not(target_os = "openbsd")
 ))] // FIXME: for currently not working platforms
+#[cfg_attr(wasi_runner, ignore = "WASI: tail follow mode disabled")]
 fn test_follow_name_move_retry1() {
     // Similar to test_follow_name_move1 but with `--retry` (`-F`)
     // This test triggers two move/rename events while `tail --follow=name --retry file` is running.
@@ -2602,6 +2622,7 @@ fn test_follow_name_move_retry1() {
     not(target_os = "freebsd"),
     not(target_os = "openbsd")
 ))] // FIXME: for currently not working platforms
+#[cfg_attr(wasi_runner, ignore = "WASI: tail follow mode disabled")]
 fn test_follow_name_move_retry2() {
     // inspired by: "gnu/tests/tail-2/F-vs-rename.sh"
     // Similar to test_follow_name_move2 (move to a name that's already monitored)
@@ -2793,6 +2814,7 @@ fn test_fifo() {
     not(target_os = "freebsd"),
     not(target_os = "openbsd")
 ))]
+#[cfg_attr(wasi_runner, ignore = "WASI: no FIFO/mkfifo support")]
 fn test_fifo_with_pid() {
     use std::process::{Command, Stdio};
 
@@ -4132,6 +4154,7 @@ fn test_args_when_settings_check_warnings_then_shows_warnings() {
 /// TODO: Write similar tests for windows
 #[test]
 #[cfg(target_os = "linux")]
+#[cfg_attr(wasi_runner, ignore = "WASI: tail follow mode disabled")]
 fn test_args_when_settings_check_warnings_follow_indefinitely_then_warning() {
     let scene = TestScenario::new(util_name!());
 
@@ -4632,6 +4655,7 @@ fn test_args_when_directory_given_shorthand_big_f_together_with_retry() {
     not(target_os = "openbsd"),
     not(feature = "feat_selinux") // flaky
 ))]
+#[cfg_attr(wasi_runner, ignore = "WASI: tail follow mode disabled")]
 fn test_follow_when_files_are_pointing_to_same_relative_file_and_file_stays_same_size() {
     let scene = TestScenario::new(util_name!());
     let at = &scene.fixtures;
@@ -5002,6 +5026,7 @@ fn test_obsolete_encoding_windows() {
 
 #[test]
 #[cfg(not(target_vendor = "apple"))] // FIXME: for currently not working platforms
+#[cfg_attr(wasi_runner, ignore = "WASI: tail follow mode disabled")]
 fn test_following_with_pid() {
     use std::process::Command;
 
@@ -5121,6 +5146,7 @@ fn test_failed_write_is_reported() {
 
 #[test]
 #[cfg(target_os = "linux")]
+#[cfg_attr(wasi_runner, ignore = "WASI sandbox: host paths not visible")]
 fn test_dev_zero() {
     new_ucmd!()
         .args(&["-c", "1", "/dev/zero"])
@@ -5165,6 +5191,7 @@ fn test_follow_pipe_f() {
 
 #[test]
 #[cfg(target_os = "linux")]
+#[cfg_attr(wasi_runner, ignore = "WASI: tail follow mode disabled")]
 fn test_follow_stdout_pipe_close() {
     let (at, mut ucmd) = at_and_ucmd!();
     at.write("f", "line1\nline2\n");
@@ -5201,6 +5228,7 @@ fn test_debug_flag_with_polling() {
 
 #[test]
 #[cfg(target_os = "linux")]
+#[cfg_attr(wasi_runner, ignore = "WASI: tail follow mode disabled")]
 fn test_debug_flag_with_inotify() {
     let ts = TestScenario::new(util_name!());
     let at = &ts.fixtures;
@@ -5218,6 +5246,7 @@ fn test_debug_flag_with_inotify() {
 
 #[test]
 #[cfg(target_os = "linux")]
+#[cfg_attr(wasi_runner, ignore = "WASI: tail follow mode disabled")]
 fn test_follow_dangling_symlink() {
     let (at, mut ucmd) = at_and_ucmd!();
     at.symlink_file("target", "link");
@@ -5232,6 +5261,7 @@ fn test_follow_dangling_symlink() {
 
 #[test]
 #[cfg(target_os = "linux")]
+#[cfg_attr(wasi_runner, ignore = "WASI: tail follow mode disabled")]
 fn test_follow_symlink_target_change() {
     let (at, mut ucmd) = at_and_ucmd!();
     at.write("t1", "A\n");