Skip to content

Commit 7c34168

Browse files
committed
Fix cspell errors in CI
1 parent e6f63b1 commit 7c34168

8 files changed

Lines changed: 12 additions & 10 deletions

File tree

docs/src/wasi-test-gaps.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
<!-- spell-checker:ignore tzdata preopen setrlimit NOFILE filestat kqueue sysinfo EISDIR ELOOP -->
2+
13
# WASI integration test gaps
24

35
Tests annotated with `#[cfg_attr(wasi_runner, ignore = "...")]` are skipped when running integration tests against a WASI binary via wasmtime. This document tracks the reasons so that gaps in WASI support are visible in one place.
@@ -46,7 +48,7 @@ The WASI sandbox does not ship locale data, so `setlocale`/`LC_ALL` have no effe
4648

4749
## WASI: tail follow mode disabled
4850

49-
`tail -f` / `tail -F` (follow mode) requires change-notification mechanisms (`inotify`, `kqueue`) and signal handling that WASI does not provide, so follow is disabled on WASI and a warning is emitted. Tests that exercise follow behaviour are skipped.
51+
`tail -f` / `tail -F` (follow mode) requires change-notification mechanisms (`inotify`, `kqueue`) and signal handling that WASI does not provide, so follow is disabled on WASI and a warning is emitted. Tests that exercise follow behavior are skipped.
5052

5153
## WASI: cannot detect unsafe overwrite
5254

@@ -62,15 +64,15 @@ wasi-libc does not ship tzdata, so `TZ` is not honoured and timezone-dependent v
6264

6365
## WASI: guest root is a writable preopen
6466

65-
The test harness maps the per-test working directory as the guest's `/`. That makes `/` writable inside the guest, so GNU-style protections against operating on the system root (e.g. `touch /` failing) cannot be exercised. It also means guest-visible absolute paths are rooted at `/`, not at the host tempdir. Tests that compare against host `canonicalize()` results or pass host absolute paths into the guest (for example some `cp --parents`, `readlink`, `realpath`, `pwd`, and `ls` cases) need guest-aware expectations or separate coverage. Tests that assert the root-protection behaviour are skipped.
67+
The test harness maps the per-test working directory as the guest's `/`. That makes `/` writable inside the guest, so GNU-style protections against operating on the system root (e.g. `touch /` failing) cannot be exercised. It also means guest-visible absolute paths are rooted at `/`, not at the host tempdir. Tests that compare against host `canonicalize()` results or pass host absolute paths into the guest (for example some `cp --parents`, `readlink`, `realpath`, `pwd`, and `ls` cases) need guest-aware expectations or separate coverage. Tests that assert the root-protection behavior are skipped.
6668

6769
## WASI: `touch -` (stdout) unsupported
6870

6971
On WASI, `touch -` returns `UnsupportedPlatformFeature` because the guest cannot reliably locate the host file backing stdout. Tests that exercise `touch -` are skipped.
7072

7173
## WASI: rlimit/setrlimit not supported
7274

73-
WASI has no concept of per-process resource limits, so `setrlimit` (and the `rlimit` crate that wraps it) has no effect. Tests that set `RLIMIT_NOFILE` to verify behaviour under restricted file-descriptor budgets are skipped.
75+
WASI has no concept of per-process resource limits, so `setrlimit` (and the `rlimit` crate that wraps it) has no effect. Tests that set `RLIMIT_NOFILE` to verify behavior under restricted file-descriptor budgets are skipped.
7476

7577
## WASI: sysinfo/meminfo not available
7678

src/uu/cp/src/cp.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
//
33
// For the full copyright and license information, please view the LICENSE
44
// file that was distributed with this source code.
5-
// spell-checker:ignore (ToDO) copydir ficlone fiemap ftruncate linkgs lstat nlink nlinks pathbuf pwrite reflink strs xattrs symlinked deduplicated advcpmv nushell IRWXG IRWXO IRWXU IRWXUGO IRWXU IRWXG IRWXO IRWXUGO sflag
5+
// spell-checker:ignore (ToDO) copydir ficlone fiemap filestat ftruncate linkgs lstat nlink nlinks pathbuf pwrite reflink strs utimensat xattrs symlinked deduplicated advcpmv nushell IRWXG IRWXO IRWXU IRWXUGO IRWXU IRWXG IRWXO IRWXUGO sflag
66

77
use std::cmp::Ordering;
88
use std::collections::{HashMap, HashSet};

src/uu/touch/src/touch.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
// For the full copyright and license information, please view the LICENSE
44
// file that was distributed with this source code.
55

6-
// spell-checker:ignore (ToDO) datelike datetime filetime lpszfilepath mktime strtime timelike utime DATETIME UTIME futimens
6+
// spell-checker:ignore (ToDO) datelike datetime filetime lpszfilepath mktime strtime timelike utime utimensat DATETIME UTIME futimens
77
// spell-checker:ignore (FORMATS) MMDDhhmm YYYYMMDDHHMM YYMMDDHHMM YYYYMMDDHHMMS
88

99
pub mod error;

src/uucore/src/lib/features/fs.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
//! Set of functions to manage regular files, special files, and links.
77
8-
// spell-checker:ignore backport
8+
// spell-checker:ignore backport preopen
99

1010
#[cfg(unix)]
1111
use libc::mkfifo;

tests/by-util/test_cat.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
//
33
// For the full copyright and license information, please view the LICENSE
44
// file that was distributed with this source code.
5-
// spell-checker:ignore NOFILE nonewline cmdline
5+
// spell-checker:ignore NOFILE nonewline cmdline setrlimit ELOOP
66

77
#[cfg(any(target_os = "linux", target_os = "android"))]
88
use rlimit::Resource;

tests/by-util/test_sort.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
// For the full copyright and license information, please view the LICENSE
44
// file that was distributed with this source code.
55

6-
// spell-checker:ignore (words) ints (linux) NOFILE dfgi abmon avril
6+
// spell-checker:ignore (words) ints (linux) NOFILE dfgi abmon avril setrlimit EISDIR
77
#![allow(clippy::cast_possible_wrap)]
88

99
use std::env;

tests/by-util/test_tail.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
// file that was distributed with this source code.
55

66
// spell-checker:ignore (ToDO) abcdefghijklmnopqrstuvwxyz efghijklmnopqrstuvwxyz vwxyz emptyfile file siette ocho nueve diez MULT
7-
// spell-checker:ignore (libs) kqueue
7+
// spell-checker:ignore (libs) kqueue ELOOP EISDIR
88
// spell-checker:ignore (jargon) tailable untailable datasame runneradmin tmpi
99
// spell-checker:ignore (cmd) taskkill
1010
#![allow(

tests/by-util/test_touch.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
//
33
// For the full copyright and license information, please view the LICENSE
44
// file that was distributed with this source code.
5-
// spell-checker:ignore (formats) cymdhm cymdhms datetime mdhm mdhms mktime strtime ymdhm ymdhms
5+
// spell-checker:ignore (formats) cymdhm cymdhms datetime filestat mdhm mdhms mktime preopen strtime tzdb ymdhm ymdhms
66

77
use filetime::FileTime;
88
#[cfg(not(target_os = "freebsd"))]

0 commit comments

Comments
 (0)