Skip to content

Commit be72dcb

Browse files
committed
perf: increase cksum benchmark workloads for meaningful timing
- Increase file sizes from 50MB to 100MB for all algorithm benchmarks - Increase multiple_files test from 25MB to 50MB per file - Ensures all benchmarks measure algorithm performance (ms) not startup overhead (µs) - Addresses reviewer feedback about benchmarks running too fast
1 parent 70680ea commit be72dcb

1 file changed

Lines changed: 7 additions & 9 deletions

File tree

src/uu/cksum/benches/cksum_bench.rs

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ macro_rules! bench_algorithm {
1212
($algo_name:ident, $algo_str:expr) => {
1313
#[divan::bench]
1414
fn $algo_name(bencher: Bencher) {
15-
let data = text_data::generate_by_size(50, 80);
15+
let data = text_data::generate_by_size(100, 80);
1616
let file_path = setup_test_file(&data);
1717

1818
bencher.bench(|| {
@@ -26,7 +26,7 @@ macro_rules! bench_algorithm {
2626
($algo_name:ident, $algo_str:expr, length) => {
2727
#[divan::bench]
2828
fn $algo_name(bencher: Bencher) {
29-
let data = text_data::generate_by_size(50, 80);
29+
let data = text_data::generate_by_size(100, 80);
3030
let file_path = setup_test_file(&data);
3131

3232
bencher.bench(|| {
@@ -67,7 +67,7 @@ bench_algorithm!(cksum_shake256, "shake256", length);
6767
/// Benchmark cksum with default CRC algorithm
6868
#[divan::bench]
6969
fn cksum_default(bencher: Bencher) {
70-
let data = text_data::generate_by_size(50, 80);
70+
let data = text_data::generate_by_size(100, 80);
7171
let file_path = setup_test_file(&data);
7272

7373
bencher.bench(|| {
@@ -78,7 +78,7 @@ fn cksum_default(bencher: Bencher) {
7878
/// Benchmark cksum with raw output format
7979
#[divan::bench]
8080
fn cksum_raw_output(bencher: Bencher) {
81-
let data = text_data::generate_by_size(50, 80);
81+
let data = text_data::generate_by_size(100, 80);
8282
let file_path = setup_test_file(&data);
8383

8484
bencher.bench(|| {
@@ -94,9 +94,9 @@ fn cksum_raw_output(bencher: Bencher) {
9494
fn cksum_multiple_files(bencher: Bencher) {
9595
bencher
9696
.with_inputs(|| {
97-
let data1 = text_data::generate_by_size(25, 80);
98-
let data2 = text_data::generate_by_size(25, 80);
99-
let data3 = text_data::generate_by_size(25, 80);
97+
let data1 = text_data::generate_by_size(50, 80);
98+
let data2 = text_data::generate_by_size(50, 80);
99+
let data3 = text_data::generate_by_size(50, 80);
100100

101101
let file1 = setup_test_file(&data1);
102102
let file2 = setup_test_file(&data2);
@@ -116,8 +116,6 @@ fn cksum_multiple_files(bencher: Bencher) {
116116
});
117117
}
118118

119-
120-
121119
fn main() {
122120
divan::main();
123121
}

0 commit comments

Comments
 (0)