tty: add missing newline to output by ChrisX101010 · Pull Request #10252 · uutils/coreutils

ChrisX101010 · 2026-01-15T00:03:17Z

ChrisDryden · 2026-01-15T00:12:44Z

@@ -37,7 +37,10 @@ pub fn uumain(args: impl uucore::Args) -> UResult<()> {
    let name = nix::unistd::ttyname(std::io::stdin());

    let write_result = match name {
-        Ok(name) => stdout.write_all_os(name.as_os_str()),
+        Ok(name) => {
+            stdout.write_all_os(name.as_os_str())?;


(/bin/tty >&- 2>/dev/null); echo $?

This command shows what happens when theres an error in writing to stdout, the error code that GNU is expecting is 3, but by adding that ? it will make it handled and return a 1. You can get around this by doing:

Ok(name) => stdout .write_all_os(name.as_os_str()) .and_then(|_| writeln!(stdout)),

target/debug/tty > /dev/full silently returns 3. But GNU have tty: write error: No space left on device.

ChrisX101010 · 2026-01-15T01:00:07Z

@ChrisDryden can you check now, sir? thank you!

oech3 · 2026-01-15T04:49:40Z

Would you add test to check newline (and exit code of >/dev/full if possible ) to
https://github.com/uutils/coreutils/blob/main/tests/by-util/test_tty.rs ? Thankyou.

github-actions · 2026-01-15T06:07:37Z

GNU testsuite comparison:

Note: The gnu test tests/basenc/bounded-memory is now being skipped but was previously passing.

ChrisX101010 · 2026-01-17T01:57:12Z

@oech3 Hi, sir! Please check now and let me know. Thank you! Have a nice weekend. :)

ChrisDryden · 2026-01-17T02:15:38Z

-    if write_result.is_err() || stdout.flush().is_err() {
+
+if let Err(e) = write_result {
+        eprintln!("tty: write error: {}", e);


Why did you change this?

@ChrisDryden I removed it because I thought it was redundant (flush was already called in line 37), but I've now restored it to match the original pattern.

I guess we can extract it from OS provided err message.
(Also please cargo fmt)

ChrisX101010 · 2026-01-17T03:26:22Z

I changed it to print the error message before exiting (as requested in the previous feedback about matching GNU tty's 'write error' output).

However, I notice I removed the separate stdout.flush() check. The flush is still being called in the Ok(name) branch (line 37), but I can restore the separate check if you prefer. Should I keep both checks separately?

codspeed-hq · 2026-01-17T06:32:23Z

Merging this PR will not alter performance

✅ 309 untouched benchmarks
⏩ 46 skipped benchmarks¹

_{Comparing ChrisX101010:fix-tty-missing-newline (de6e612) with main (26223ad)}

46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

sylvestre · 2026-01-17T16:46:01Z

many jobs are failing

ChrisX101010 · 2026-01-17T17:02:24Z

many jobs are failing

I ran tests locally, and everything worked for me. I don't know why these specific jobs keep failing when I fixed the new line issue. There is no other workaround that I know of, GNU panics if something is wrong but it didn't produce an output so I made custom test like OP mentioned and I don't understand why is it failing now.. Can you suggest fix to this?

oech3 · 2026-01-17T17:10:06Z

I guess you wrote the test writing to /dev/full based on @naoNao89 wrote one.
When I tried to do same things at different PR to remove panic, it failed.

I guess it is generic test framefork's issue.

ChrisX101010 · 2026-01-17T17:15:19Z

I guess you wrote the test writing to /dev/full based on @naoNao89 wrote one. When I tried to do same things at different PR to remove panic, it failed.

I guess it is generic test framefork's issue.

Thank you, sir. If it's okay on your end, can we close this issue for now and this other issue can be a separate PR?

oech3 · 2026-01-17T17:22:14Z

Please keep open and add ignore to the test.

ChrisX101010 · 2026-01-17T17:24:07Z

Please keep open and add ignore to the test.

Understood, sir. Will follow your advice, thank you for the suggestion.

ChrisX101010 · 2026-01-18T14:49:15Z

@oech3 done, sir.

github-actions · 2026-01-18T15:01:00Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

sylvestre · 2026-01-18T15:10:52Z

Some jobs are failing

oech3 · 2026-02-05T16:47:50Z

conflicting.

ChrisX101010 · 2026-02-05T17:58:38Z

conflicting.

What do you suggest to fix this issue?

Thank you in advance, sir. 🙏

Best,
Chris

oech3 · 2026-02-09T09:33:06Z

Would you rebase agaist main locally?

ChrisX101010 · 2026-02-09T09:37:06Z

Would you rebase agaist main locally?

Yes, sir. Give me some time I will finish today. 🫡

oech3 · 2026-04-17T18:43:22Z

Do you still want to do this?

ChrisX101010 · 2026-04-17T18:47:18Z

Do you still want to do this?

I will clean up today. Thanks! 🙏 will work on it now. After I finish this one, could you please add me to other issues I wanna practice and improve my Rust skills. 🙂 I will check what is the issue, CI/CD tests I think crashing.

ChrisX101010 · 2026-04-17T18:47:50Z

Do you still want to do this?

I apologize I was away, I had some private stuff to finish.

ChrisX101010 · 2026-04-17T19:32:35Z

Do you still want to do this?

I've rebased against main and resolved all conflicts. The performance regression flagged by CodSpeed has been fixed by combining the tty path and newline into a single buffer before writing:

rust
let mut buf = name.as_bytes().to_vec();
buf.push(b'\n');
stdout.write_all(&buf)
This reduces the I/O operations from three to two (one write + one flush), eliminating the 3.26% overhead. All tests pass locally including newline output and /dev/full error handling (exit code 3).

github-actions · 2026-04-18T05:13:50Z

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/tail-n0f (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cut/bounded-memory is now passing!

ChrisDryden reviewed Jan 15, 2026

View reviewed changes

ChrisDryden reviewed Jan 17, 2026

View reviewed changes

ChrisX101010 force-pushed the fix-tty-missing-newline branch from 2c92d38 to b88708c Compare January 18, 2026 14:48

tty: add missing newline to output Fixes uutils#10239

de6e612

ChrisX101010 force-pushed the fix-tty-missing-newline branch from b88708c to de6e612 Compare April 17, 2026 19:28

Uh oh!

Conversation

ChrisX101010 commented Jan 15, 2026

Uh oh!

ChrisDryden Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

oech3 Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

ChrisX101010 commented Jan 15, 2026

Uh oh!

oech3 commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 15, 2026

Uh oh!

ChrisX101010 commented Jan 17, 2026

Uh oh!

ChrisDryden Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

ChrisX101010 Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

oech3 Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

ChrisX101010 commented Jan 17, 2026

Uh oh!

codspeed-hq Bot commented Jan 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

sylvestre commented Jan 17, 2026

Uh oh!

ChrisX101010 commented Jan 17, 2026

Uh oh!

oech3 commented Jan 17, 2026

Uh oh!

ChrisX101010 commented Jan 17, 2026

Uh oh!

oech3 commented Jan 17, 2026

Uh oh!

ChrisX101010 commented Jan 17, 2026

Uh oh!

ChrisX101010 commented Jan 18, 2026

Uh oh!

github-actions Bot commented Jan 18, 2026

Uh oh!

sylvestre commented Jan 18, 2026

Uh oh!

oech3 commented Feb 5, 2026

Uh oh!

ChrisX101010 commented Feb 5, 2026

Uh oh!

oech3 commented Feb 9, 2026

Uh oh!

ChrisX101010 commented Feb 9, 2026

Uh oh!

oech3 commented Apr 17, 2026

Uh oh!

ChrisX101010 commented Apr 17, 2026

Uh oh!

ChrisX101010 commented Apr 17, 2026

Uh oh!

ChrisX101010 commented Apr 17, 2026

Uh oh!

github-actions Bot commented Apr 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

oech3 commented Jan 15, 2026 •

edited

Loading

codspeed-hq Bot commented Jan 17, 2026 •

edited

Loading