Skip to content

ci: specify bash shell for background jobs#10491

Merged
sylvestre merged 1 commit into
uutils:mainfrom
xtqqczze:background-bash
May 20, 2026
Merged

ci: specify bash shell for background jobs#10491
sylvestre merged 1 commit into
uutils:mainfrom
xtqqczze:background-bash

Conversation

@xtqqczze
Copy link
Copy Markdown
Contributor

GitHub Actions defaults to PowerShell on some runners, which swallows background job output and can behave differently with &.

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/follow-name (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/tail/retry is no longer failing!

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/tail/retry is no longer failing!

@xtqqczze

This comment was marked as outdated.

@xtqqczze xtqqczze marked this pull request as draft January 26, 2026 18:56
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 15, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/retry (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.
Note: The gnu test tests/tail/tail-n0f is now being skipped but was previously passing.
Skip an intermittent issue tests/pr/bounded-memory (was skipped on 'main', now failing)

@xtqqczze

This comment was marked as outdated.

@xtqqczze

This comment was marked as outdated.

@xtqqczze xtqqczze marked this pull request as ready for review May 15, 2026 19:30
GitHub Actions defaults to PowerShell on some runners, which swallows
background job output and can behave differently with `&`.
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 15, 2026

Merging this PR will improve performance by 13.71%

⚡ 2 improved benchmarks
✅ 315 untouched benchmarks
⏩ 46 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory cp_recursive_deep_tree[(120, 4)] 699.2 KB 562.5 KB +24.31%
Simulation ls_recursive_balanced_tree[(6, 4, 15)] 50.9 ms 48.9 ms +4.01%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing xtqqczze:background-bash (3b673bf) with main (d09f351)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Copy Markdown
Contributor

@sylvestre sylvestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — safe CI fix.

Copy link
Copy Markdown
Contributor

@sylvestre sylvestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — safe CI fix.

@sylvestre sylvestre merged commit 5547962 into uutils:main May 20, 2026
169 checks passed
@xtqqczze xtqqczze deleted the background-bash branch May 20, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants