Skip to content

uucore: remove process functions#11158

Open
xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:rm-getpid
Open

uucore: remove process functions#11158
xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:rm-getpid

Conversation

@xtqqczze
Copy link
Copy Markdown
Contributor

@xtqqczze xtqqczze commented Feb 28, 2026

Closes #12342

Remove wrapper functions from uucore::process and use rustix directly in each crate.

@sylvestre
Copy link
Copy Markdown
Contributor

are you sure it isn't used by other consumers of uucore ?

@xtqqczze
Copy link
Copy Markdown
Contributor Author

xtqqczze commented Feb 28, 2026

are you sure it isn't used by other consumers of uucore ?

nushell depends on uucore crate but not these functions, but other coreutils repos do:

https://github.com/uutils/procps/blob/4ebf73c7129c4ef637f2551690e8d72b861ff4f0/src/uu/pgrep/src/process.rs#L494

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/symlink (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/misc/io-errors is no longer failing!
Congrats! The gnu test tests/timeout/timeout-group is no longer failing!
Congrats! The gnu test tests/tail/tail-n0f is now passing!

@xtqqczze xtqqczze marked this pull request as draft February 28, 2026 14:59
@sylvestre
Copy link
Copy Markdown
Contributor

@xtqqczze still draft, no ? :)

@xtqqczze xtqqczze marked this pull request as ready for review May 17, 2026 01:28
@xtqqczze
Copy link
Copy Markdown
Contributor Author

Downstream: uutils/procps#701

@xtqqczze xtqqczze changed the title uucore: remove unused getpid and getsid functions uucore: remove process functions May 17, 2026
@xtqqczze xtqqczze marked this pull request as draft May 17, 2026 02:17
@xtqqczze xtqqczze force-pushed the rm-getpid branch 5 times, most recently from 2c77483 to b6bb40e Compare May 17, 2026 02:32
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 17, 2026

Merging this PR will not alter performance

✅ 319 untouched benchmarks
⏩ 46 skipped benchmarks1


Comparing xtqqczze:rm-getpid (3203759) with main (7ea1211)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 17, 2026

GNU testsuite comparison:

Congrats! The gnu test tests/cp/link-heap is now passing!
Congrats! The gnu test tests/tail/tail-n0f is now passing!

@xtqqczze xtqqczze force-pushed the rm-getpid branch 4 times, most recently from 61f571c to b94021b Compare May 17, 2026 10:43
@xtqqczze xtqqczze marked this pull request as ready for review May 17, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants