Skip to content

nproc: Reject quota with some schedulers#11173

Merged
sylvestre merged 1 commit into
uutils:mainfrom
oech3:nproc-s
May 26, 2026
Merged

nproc: Reject quota with some schedulers#11173
sylvestre merged 1 commit into
uutils:mainfrom
oech3:nproc-s

Conversation

@oech3

@oech3 oech3 commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

Closes #9893 .
Difficult to add test. Also needs another fix to pass GNU tests.

@github-actions

github-actions Bot commented Mar 2, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/follow-name (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/rm/isatty is no longer failing!
Note: The gnu test tests/nproc/nproc-quota was skipped on 'main' but is now failing.

@oech3

oech3 commented Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

Note: The gnu test tests/nproc/nproc-quota was skipped on 'main' but is now failing.

libc function was detected.

@oech3 oech3 marked this pull request as ready for review March 2, 2026 06:00
Comment thread src/uu/nproc/src/nproc.rs Outdated
Comment thread src/uu/nproc/src/nproc.rs
@github-actions

github-actions Bot commented Mar 4, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Note: The gnu test tests/nproc/nproc-quota was skipped on 'main' but is now failing.

@oech3

This comment was marked as resolved.

@github-actions

github-actions Bot commented Mar 4, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

GNU test failed: tests/tail/retry. tests/tail/retry is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/nproc/nproc-quota was skipped on 'main' but is now failing.

@oech3

This comment was marked as resolved.

@oech3

This comment was marked as resolved.

@github-actions

github-actions Bot commented Mar 4, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Note: The gnu test tests/nproc/nproc-quota was skipped on 'main' but is now failing.

@codspeed-hq

codspeed-hq Bot commented Mar 4, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 319 untouched benchmarks
⏩ 46 skipped benchmarks1


Comparing oech3:nproc-s (e7b9033) with main (29fdaa6)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions

github-actions Bot commented Mar 6, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/dd/no-allocate is now being skipped but was previously passing.
Note: The gnu test tests/seq/seq-epipe is now being skipped but was previously passing.
Note: The gnu test tests/nproc/nproc-quota was skipped on 'main' but is now failing.

@oech3

This comment was marked as outdated.

@github-actions

github-actions Bot commented Mar 8, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/date/resolution (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/cut/bounded-memory is now being skipped but was previously passing.
Congrats! The gnu test tests/rm/many-dir-entries-vs-OOM is now passing!
Congrats! The gnu test tests/tail/pipe-f is now passing!
Note: The gnu test tests/nproc/nproc-quota was skipped on 'main' but is now failing.

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/tail/pipe-f is now passing!
Note: The gnu test tests/nproc/nproc-quota was skipped on 'main' but is now failing.

@oech3

This comment was marked as outdated.

@oech3

oech3 commented Mar 31, 2026

Copy link
Copy Markdown
Contributor Author

I tried to replace unsafe libc with rustix, but failed.
I know tests/nproc/nproc-quota needs LD_PRELOAD, but which tests same things with nproc-quota-masked-proc (submitted by me).

@oech3

oech3 commented Apr 26, 2026

Copy link
Copy Markdown
Contributor Author

is this OK?

@oech3

oech3 commented May 1, 2026

Copy link
Copy Markdown
Contributor Author

@cakebaker @sylvestre Is this OK to merge?

@oech3 oech3 force-pushed the nproc-s branch 2 times, most recently from 1cee571 to e7b9033 Compare May 25, 2026 16:36
@oech3

oech3 commented May 26, 2026

Copy link
Copy Markdown
Contributor Author

@sylvestre Would you merge this?

@sylvestre

Copy link
Copy Markdown
Contributor

sorry
can we get an android specific test for this?

@oech3

oech3 commented May 26, 2026

Copy link
Copy Markdown
Contributor Author

I think it is difficult due to sudo dep.

@sylvestre sylvestre merged commit c1a3f6f into uutils:main May 26, 2026
171 of 173 checks passed
@oech3 oech3 deleted the nproc-s branch May 26, 2026 11:24
@oech3

oech3 commented May 26, 2026

Copy link
Copy Markdown
Contributor Author

But we should catch regression when tests/nproc/nproc-quota was disabled.

@oech3

oech3 commented May 26, 2026

Copy link
Copy Markdown
Contributor Author

Fixing #9815 should enable a GnuTest to avoid regression of this. But I cannot do that soon. I don't know any reasonable way to get quota.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nproc: nproc-quota.sh?: Rejects schedular

2 participants