Skip to content

GNUmakefile: Do not depend on system tr for Gentoo#11345

Merged
sylvestre merged 2 commits intouutils:mainfrom
oech3:make-tr
Mar 21, 2026
Merged

GNUmakefile: Do not depend on system tr for Gentoo#11345
sylvestre merged 2 commits intouutils:mainfrom
oech3:make-tr

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented Mar 16, 2026

Closes #11101 Closes #11252 Closes #11260

@oech3 oech3 force-pushed the make-tr branch 3 times, most recently from d70390c to 0883bf1 Compare March 16, 2026 10:12
@vincentdephily
Copy link
Copy Markdown

 Testing make install with l10n features...
sed: 1: "/feat_Tier1 = \[/,/\]/{ ...": extra characters at the end of p command
sed: 1: "/feat_common_core = \[/ ...": extra characters at the end of p command
sed: 1: "/feat_require_unix_core ...": extra characters at the end of p command
GNUmakefile:85: *** unterminated call to function `shell': missing `)'.  Stop.

Fair enough, macOS sed doesn't like that syntax somehow, thanks for retrying. Not sure what would please it, the error message doesn't make much sense to me and I don't have an OS to look for a fix. #11101 seems to have other solutions anyway.

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/printf/printf-surprise is now passing!
Congrats! The gnu test tests/seq/seq-epipe is now passing!

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/resolution (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/tail/tail-n0f is now being skipped but was previously passing.
Note: The gnu test tests/unexpand/bounded-memory is now being skipped but was previously passing.
Congrats! The gnu test tests/printf/printf-surprise is now passing!
Congrats! The gnu test tests/seq/seq-epipe is now passing!

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Mar 16, 2026

fixed

@oech3 oech3 marked this pull request as ready for review March 16, 2026 11:29
Comment thread GNUmakefile Outdated
@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/printf/printf-surprise is now passing!
Congrats! The gnu test tests/seq/seq-epipe is now passing!

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Mar 21, 2026

is this ok to merge?

@sylvestre sylvestre merged commit 33d698b into uutils:main Mar 21, 2026
161 checks passed
@oech3 oech3 deleted the make-tr branch March 21, 2026 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GNUmakefile: OS should be based on rustc --print host-tuple and CARGO_BUILD_TARGET Makefile should fail early when initial info gathering fails

3 participants