tr: fix complemented class truncation ordering#11406
Merged
sylvestre merged 3 commits intouutils:mainfrom Apr 20, 2026
Merged
Conversation
cakebaker
reviewed
Mar 26, 2026
Comment on lines
+344
to
+351
| #[test] | ||
| fn test_truncate_applies_before_complement_with_class() { | ||
| new_ucmd!() | ||
| .args(&["-ct", "[:digit:]", "X"]) | ||
| .pipe_in("A") | ||
| .succeeds() | ||
| .stdout_is("X"); | ||
| } |
Contributor
There was a problem hiding this comment.
This test is incorrect because it contradicts your reproduction steps:
printf A | tr -ct '[:digit:]' X
# Expected (GNU): exit 1 with "when translating with complemented character classes, string2 must map all characters in the domain to one"
Contributor
Author
There was a problem hiding this comment.
my bad, it's the rejection test. will push the inverse
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uutils
trapplies the complemented-character-class guard before--truncate-set1, then truncates the translated set afterward. That allows-ctto translate only a subset of complemented bytes, while GNU rejects this shape instead of allowing partial mapping.Reproduction Steps
Impact
This breaks GNU compatibility and weakens sanitization pipelines that rely on
tr -ctto enforce translation coverage. Inputs that should be rejected can be accepted with under-filtered output.