rm: use "traversal failed" message when readdir fails during recursive removal by kevinburkesegment · Pull Request #11427 · uutils/coreutils

kevinburkesegment · 2026-03-20T05:41:33Z

When readdir fails mid-traversal (e.g., due to I/O errors), GNU rm reports "traversal failed:

" rather than "cannot remove ''". Update the error handling in safe_remove_dir_recursive_impl to match this behavior.

Fixes GNU test: tests/rm/rm-readdir-fail.sh

sylvestre · 2026-04-04T08:20:59Z

sorry but could you please add a test to cover this case ?

Switch to unstable sorting as it is in-place, and remove an unnecessary string conversion.

Also switches to var_os for alloc-free code.

Remove format machinery, an unnecessary allocation and a duplicated function.

Should improve codegen, especially in debug mode.

…_info

Renames and documents PathDataDisplayName::Moo to _::Custom; also makes code more idiomatic and restores an accidentally-removed warning. Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com> Co-authored-by: xtqqczze <45661989+xtqqczze@users.noreply.github.com>

…ed→supprimé)

…uutils#11673) * dd: do not show zero multiplier warning when zero is the multiplicand * tests/dd: test zero multiplier warning when zero is the multiplicand

…uffix and fixed String format (uutils#11674) * numfmt: preserve fractional digits when --from-unit is used without suffix and fixed String format * numfmt: simplify redundant if branches caught by clippy * numfmt: fix precision condition to only preserve decimals when input has no unit suffix

Formats like "%-e" previously bypassed ICU localization of "%b"/"%A" because the modifier fast-path ran before localize_format_string(). Localize first, then run the modifier pass on the already-localized format. Fixes uutils#11240.

github-actions · 2026-04-06T18:04:55Z

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/tail/retry is no longer failing!
Congrats! The gnu test tests/rm/many-dir-entries-vs-OOM is now passing!

…e removal Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

sylvestre · 2026-04-20T20:25:23Z

please reopen when it is ready

kevinburkesegment force-pushed the rm-traversal-failed branch from 15ad1ee to ed919a4 Compare March 20, 2026 16:44

RenjiSann and others added 28 commits April 6, 2026 10:48

test(cksum): Test for cksum -a blake3

1c9c9e4

bench(cksum): Re-enable blake3 benchmarks

4129d99

ls: add header to new files

0fc85a2

l10n.yml: drop cargo build covered by cargo {test,run}

303a0f3

chore(deps): update rust crate zip to v8.3.1

991b128

fix(ls): reduce allocations on PathData struct

908c0bc

fix(ls): reduce allocations on sorting

12554dd

Switch to unstable sorting as it is in-place, and remove an unnecessary string conversion.

fix(ls): remove various redundant clones

abd8df3

fix(ls): reduce duplicated time syscalls

60eb952

fix(ls): optimize create_hyperlink and make it loseless.

232dbf3

fix(ls): do not allocate for symlink len check

27fd852

fix(ls): fix double-lookup of (COLOR)TERM env vars

1569d0d

Also switches to var_os for alloc-free code.

fix(ls): fix double-allocation of block options

4bccb7b

fix(ls): use Cow on parse_time_style to reduce allocations

73bc8a8

fix(ls): remove various useless LineEnding::to_string()

a5be6a7

fix(ls): do not alloc char to push to OsString in display_item_name

9dfb1c0

fix(ls): various inode optimizations

5a823fb

Remove format machinery, an unnecessary allocation and a duplicated function.

fix(ls): preallocate for a couple of vectors/strings

8fb9261

fix(ls): reuse intermediate buffer on --long

ac41191

fix(ls): use Vec::push where appropiate in display_item_long

368ae59

Should improve codegen, especially in debug mode.

fix(ls): do not dynamically dispatch display_item_name closures

6a4febe

fix(ls): do not unnecessary format & allocate on return_total

fb28dae

fix(ls): remove unnecessary allocations in display_additional_leading…

0a11492

…_info

fix(ls): remove double collect and extra allocations in display_grid

038f778

fix(ls): remove unnecessary allocations in display_item_name

afe988e

uudoc: make tldr attribution and disclaimer translatable

e4bae8e

GNUmakefile: Fix LN for cygwin

c16f5d8

sylvestre and others added 23 commits April 6, 2026 10:48

uucore: expose SI_BASES and IEC_BASES constants

379e96c

numfmt: source SI/IEC bases from uucore::parser::parse_size

d3804cc

dd: source SI/IEC bases from uucore::parser::parse_size

4f00102

df: source SI/IEC bases from uucore::parser::parse_size

af7360c

fr-FR: fix anglicisms (supporté→pris en charge, drapeau→option, remov…

55ee782

…ed→supprimé)

env: hardcode config file error message

0b0b835

cp: hardcode verbose copy/created-directory message

664e54b

install: hardcode verbose copy message

340d62d

tail: hardcode no-such-file and became-inaccessible status messages

9913be8

who: hardcode idle current/unknown placeholders

09d7fe7

mkdir: replace libc and unsafe by rustix

d78314e

numfmt: add failing test cases

ccc5185

date: add ignored tests for GNU compatibility gaps found by fuzz_date

9e67e56

pre-commit: update cargo-lock-check to suggest changes

a4dcf84

dd: do not show zero multiplier warning when zero is the multiplicand (…

e6f0687

…uutils#11673) * dd: do not show zero multiplier warning when zero is the multiplicand * tests/dd: test zero multiplier warning when zero is the multiplicand

date: fix %#P case-swap on lowercase am/pm

aa19343

date: honor narrow width on wide default strftime fields

cb18e9e

cat: remove some unnecessary to_owned() calls

be21127

head: split head.rs

23af1ad

Tests for Hungarian locale

6b5f2e6

ci: install hu_HU.UTF-8 (and peers) for l10n cargo test job

2ef0aea

kevinburkesegment force-pushed the rm-traversal-failed branch from 46290b9 to 198f365 Compare April 6, 2026 17:55

kevinburkesegment force-pushed the rm-traversal-failed branch from 198f365 to 713aeb6 Compare April 7, 2026 17:49

rm: use "traversal failed" message when readdir fails during recursiv…

1bfbb9b

…e removal Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

kevinburkesegment force-pushed the rm-traversal-failed branch from 713aeb6 to 1bfbb9b Compare April 7, 2026 18:42

sylvestre closed this Apr 20, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

rm: use "traversal failed" message when readdir fails during recursive removal#11427

rm: use "traversal failed" message when readdir fails during recursive removal#11427
kevinburkesegment wants to merge 264 commits intouutils:mainfrom
kevinburkesegment:rm-traversal-failed

kevinburkesegment commented Mar 20, 2026

Uh oh!

sylvestre commented Apr 4, 2026

Uh oh!

github-actions Bot commented Apr 6, 2026

Uh oh!

sylvestre commented Apr 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

kevinburkesegment commented Mar 20, 2026

Uh oh!

sylvestre commented Apr 4, 2026

Uh oh!

github-actions Bot commented Apr 6, 2026

Uh oh!

sylvestre commented Apr 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants