ls: `ls -lF` symlink target indicators by joknarf · Pull Request #11554 · uutils/coreutils

joknarf · 2026-03-30T21:32:46Z

Fixes #11542
gnu output incompatibility with --classify on symlink targets

before:

 • ls -lF mylink*
lrwxrwxrwx 1 user group 5 Nov 22 08:33 mylinktodir@ -> mydir
lrwxrwxrwx 1 user group 9 Nov 22 08:31 mylinktoexe@ -> myexec.sh
lrwxrwxrwx 1 user group 6 Nov 22 08:34 mylinktofile@ -> myfile
lrwxrwxrwx 1 user group 6 Nov 22 08:47 mylinktopipe@ -> mypipe
lrwxrwxrwx 1 user group 6 Mar 29 10:42 mylinktosock@ -> mysock

after (gnu identical output):

 • gnuls -lF mylink*
lrwxrwxrwx 1 user group 5 Nov 22 09:33 mylinktodir -> mydir/
lrwxrwxrwx 1 user group 9 Nov 22 09:31 mylinktoexe -> myexec.sh*
lrwxrwxrwx 1 user group 6 Nov 22 09:34 mylinktofile -> myfile
lrwxrwxrwx 1 user group 6 Nov 22 09:47 mylinktopipe -> mypipe|
lrwxrwxrwx 1 user group 6 Mar 29 10:42 mylinktosock -> mysock=

Alonely0

Looks fine, but there are a lot of removed comments (vibecode?) and unnecessary performance hits.

github-actions · 2026-03-31T05:18:07Z

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/seq/seq-epipe is now passing!

codspeed-hq · 2026-03-31T05:29:27Z

Merging this PR will degrade performance by 3.13%

⚠️

Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 318 untouched benchmarks
⏩ 46 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
❌	Simulation	`sort_long_line[10000]`	423.9 µs	437.6 µs	-3.13%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing joknarf:classify_target (89454cf) with main (aaf4a35)}

46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

sylvestre · 2026-03-31T07:18:39Z

please fix the failing tasks

Alonely0 · 2026-03-31T16:13:47Z

@joknarf For the perf-related changes I requested, please try to git-apply this patch. It should also fix the formatting-related CI failures.
perf.patch

Alonely0 · 2026-03-31T17:45:47Z

I'm happy to sign off on this code provided CI likes it, but I'd still like to save those comments and (while I don't really care), I would appreciate if you could mark me as a co-author of the apply commit and give it a descriptive name, i.e:

fix(ls): take care of performance regressions

Co-authored-by: Guillem L. Jara <4lon3ly0@tutanota.com>

Since you're gonna have to do an interactive rebase, while you're at it please change your commits to follow our etiquette. Split 4ef7830 into a fix commit and a chore one that adds the test (squash the cSpell fix onto it), and use our naming conventions for them.

joknarf · 2026-03-31T19:16:24Z

I'm happy to sign off on this code provided CI likes it, but I'd still like to save those comments and (while I don't really care), I would appreciate if you could mark me as a co-author of the apply commit and give it a descriptive name, i.e:
fix(ls): take care of performance regressions

Co-authored-by: Guillem L. Jara <4lon3ly0@tutanota.com>
Since you're gonna have to do an interactive rebase, while you're at it please change your commits to follow our etiquette. Split 4ef7830 into a fix commit and a chore one that adds the test (squash the cSpell fix onto it), and use our naming conventions for them.

Ok, I hope I did what you expect, Thank you

joknarf · 2026-03-31T19:37:32Z

uutils/gnu ls output comparison:

Alonely0 · 2026-03-31T21:39:51Z

Signed off, looks good to me. Thanks @joknarf!

@sylvestre can we get a CI run?

github-actions · 2026-03-31T22:32:11Z

GNU testsuite comparison:

Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.
Note: The gnu test tests/tail/pipe-f is now being skipped but was previously passing.
Congrats! The gnu test tests/unexpand/bounded-memory is now passing!

github-actions · 2026-04-01T09:11:31Z

GNU testsuite comparison:

Skip an intermittent issue tests/date/resolution (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)

Alonely0 · 2026-04-01T09:37:50Z

CI passes, it's x64 macOS timeout bugs at it again.

github-actions · 2026-04-16T20:36:43Z

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/misc/io-errors (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/tail-n0f (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/expand/bounded-memory is now being skipped but was previously passing.
Note: The gnu test tests/rm/many-dir-entries-vs-OOM is now being skipped but was previously passing.

Alonely0 · 2026-04-20T07:10:19Z

@joknarf please rebase to fix CI.

Co-authored-by: Guillem L. Jara <4lon3ly0@tutanota.com>

joknarf · 2026-04-20T10:20:41Z

@joknarf please rebase to fix CI.

rebase done, added fix for Sylvestre test (ls -lp symlink target without slash indicator)

Alonely0 · 2026-04-20T10:53:17Z

@sylvestre can you confirm the WASI failure is unrelated? Also it appears we hit quota in CodSpeed :/

joknarf · 2026-04-20T11:16:40Z

@joknarf please rebase to fix CI.

rebase done, added fix for Sylvestre test (ls -lp symlink target without slash indicator)

but fix not ok, need to check/test, typically: --indicator-style=file-type

joknarf · 2026-04-20T13:25:08Z

FYI, odd case behavior with gnuls, depending on LS_COLORS:

defining color for mi or or (brokenlink / missing target) changes the ls -lp --color output
(trailing slash added to target symlink + symlink target colored)
It seems it forces stat on symlink targets and use it to display

here, with ls (GNU coreutils) 9.7

joknarf · 2026-04-20T22:42:00Z

FYI, I made a PR to this branch trying to get similar behavior as gnuls, tell me if you think I should merge it here.

PR ls: ls -l ls -lp LS_COLORS can make ls stat symlink target => change indicator display/color

ls: `ls -l` `ls -lp` LS_COLORS can make ls stat symlink target => change indicator display/color

joknarf · 2026-05-27T21:19:33Z

as still no reply since month, merged the fix to have same behavior as gnu ls as for me, is the target behavior (would remove rust coreutils from any server if not gnu compatible)

sylvestre · 2026-05-28T09:44:00Z

sorry, it looks great, ready to be merged

sylvestre · 2026-05-28T09:44:10Z

but it seems i can't merged it

--------- Co-authored-by: Guillem L. Jara <4lon3ly0@tutanota.com> Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>

joknarf mentioned this pull request Mar 30, 2026

ls -lF (--classify) symlink target indicator missing #11542

Closed

joknarf force-pushed the classify_target branch 2 times, most recently from 77108f2 to c9b81dc Compare March 30, 2026 22:20

Alonely0 suggested changes Mar 30, 2026

View reviewed changes

joknarf force-pushed the classify_target branch from 92f6112 to c2f7ad6 Compare March 31, 2026 17:27

joknarf changed the title ~~ls -lF symlink target indicators~~ ls: ls -lF symlink target indicators Mar 31, 2026

joknarf force-pushed the classify_target branch 2 times, most recently from 82969f7 to 9f3dc35 Compare March 31, 2026 19:14

joknarf force-pushed the classify_target branch from 9f3dc35 to d071234 Compare March 31, 2026 19:41

Alonely0 reviewed Mar 31, 2026

View reviewed changes

Comment thread src/uu/ls/src/display.rs Outdated

joknarf force-pushed the classify_target branch from d071234 to b5a1194 Compare March 31, 2026 21:25

Alonely0 approved these changes Mar 31, 2026

View reviewed changes

joknarf and others added 4 commits April 20, 2026 11:54

ls: ls -lF symlink target indicator

982364e

tests/ls: test for ls -lF symlink indicator

f48941b

fix(ls): take care of performance regressions

43b3834

Co-authored-by: Guillem L. Jara <4lon3ly0@tutanota.com>

test(ls): add -lp slash indicator regression for symlink targets

fabaf36

joknarf force-pushed the classify_target branch from ddaa63f to 422c1a7 Compare April 20, 2026 09:54

joknarf force-pushed the classify_target branch from 422c1a7 to 1f7f97a Compare April 20, 2026 11:45

joknarf added 2 commits April 20, 2026 14:00

test(ls): add --file-type exec/dir symlink target indicator

f5f3eae

fix(ls): ls -lp symlink target w/o trailing slash

cf29c00

joknarf force-pushed the classify_target branch from 1f7f97a to cf29c00 Compare April 20, 2026 12:02

codspeed-hq Bot mentioned this pull request Apr 20, 2026

tee: merge logic of flush into write #11914

Closed

fix(ls): LS_COLORS mi= or=

517f814

Merge pull request #1 from joknarf/classify_fix

039b19c

ls: `ls -l` `ls -lp` LS_COLORS can make ls stat symlink target => change indicator display/color

Merge branch 'main' into classify_target

89454cf

sylvestre merged commit b22013a into uutils:main May 28, 2026
172 of 173 checks passed

nonontb pushed a commit to nonontb/coreutils that referenced this pull request May 28, 2026

ls: ls -lF symlink target indicators (uutils#11554)

946376b

--------- Co-authored-by: Guillem L. Jara <4lon3ly0@tutanota.com> Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>

Uh oh!

Conversation

joknarf commented Mar 30, 2026 • edited by cakebaker Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Alonely0 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Mar 31, 2026

Uh oh!

codspeed-hq Bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will degrade performance by 3.13%

Performance Changes

Footnotes

Uh oh!

sylvestre commented Mar 31, 2026

Uh oh!

Alonely0 commented Mar 31, 2026

Uh oh!

Alonely0 commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joknarf commented Mar 31, 2026

Uh oh!

joknarf commented Mar 31, 2026

Uh oh!

Uh oh!

Alonely0 commented Mar 31, 2026

Uh oh!

github-actions Bot commented Mar 31, 2026

Uh oh!

github-actions Bot commented Apr 1, 2026

Uh oh!

Alonely0 commented Apr 1, 2026

Uh oh!

github-actions Bot commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Alonely0 commented Apr 20, 2026

Uh oh!

joknarf commented Apr 20, 2026

Uh oh!

Alonely0 commented Apr 20, 2026

Uh oh!

joknarf commented Apr 20, 2026

Uh oh!

joknarf commented Apr 20, 2026

Uh oh!

joknarf commented Apr 20, 2026

Uh oh!

joknarf commented May 27, 2026

Uh oh!

sylvestre commented May 28, 2026

Uh oh!

sylvestre commented May 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

joknarf commented Mar 30, 2026 •

edited by cakebaker

Loading

codspeed-hq Bot commented Mar 31, 2026 •

edited

Loading

Alonely0 commented Mar 31, 2026 •

edited

Loading

github-actions Bot commented Apr 16, 2026 •

edited

Loading