Skip to content

numfmt: precision is ignored #11667#11683

Merged
cakebaker merged 11 commits intouutils:mainfrom
Devel08:main
Apr 10, 2026
Merged

numfmt: precision is ignored #11667#11683
cakebaker merged 11 commits intouutils:mainfrom
Devel08:main

Conversation

@Devel08
Copy link
Copy Markdown
Contributor

@Devel08 Devel08 commented Apr 6, 2026

if --format is explicitly specified as zero, it will format the number as 5M, if it's not specified as zero, by default it will format the number as 5.0M.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/date/resolution (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 6, 2026

Merging this PR will not alter performance

✅ 309 untouched benchmarks
⏩ 46 skipped benchmarks1


Comparing Devel08:main (f6a175e) with main (3fbfcf9)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/cp/link-heap is now passing!

@sylvestre
Copy link
Copy Markdown
Contributor

Please remove the ignore for the the test in test_numfmt.rs

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/rm/isatty (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/rm/many-dir-entries-vs-OOM is now being skipped but was previously passing.
Congrats! The gnu test tests/cp/link-heap is now passing!

@sylvestre
Copy link
Copy Markdown
Contributor

also, please rename the commit for something more explicit
thanks

@cakebaker cakebaker linked an issue Apr 7, 2026 that may be closed by this pull request
Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)

@sylvestre sylvestre changed the title numfmt fix #11667 numfmt: precision is ignored #11667 Apr 7, 2026
@Devel08 Devel08 marked this pull request as draft April 8, 2026 05:02
@Devel08 Devel08 marked this pull request as ready for review April 8, 2026 05:03
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/symlink (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/basenc/bounded-memory is now being skipped but was previously passing.
Note: The gnu test tests/seq/seq-epipe is now being skipped but was previously passing.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/tail/tail-n0f is now being skipped but was previously passing.

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/tail/tail-n0f is now passing!

@cakebaker cakebaker merged commit f9efb9e into uutils:main Apr 10, 2026
217 of 231 checks passed
@cakebaker
Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

numfmt: --format='%.0f' (precision 0) ignored when scaling with --to

3 participants