Skip to content

numfmt: apply prefix after scaling for --to-unit #11684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cakebaker merged 2 commits into from
Apr 7, 2026
+3 −7
Merged

numfmt: apply prefix after scaling for --to-unit #11684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd05f5d
numfmt: apply suffix after scaling
BipulLamsal Apr 6, 2026
4c29e0d
test_numfmt: remove ignore from prefix selection test
BipulLamsal Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/uu/numfmt/src/format.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,8 +487,8 @@ fn transform_to(
precision: usize,
unit_separator: &str,
) -> Result<String> {
let (i2, s) = consider_suffix(s, opts.to, round_method, precision)?;
let i2 = i2 / (opts.to_unit as f64);
let i2 = s / (opts.to_unit as f64);
let (i2, s) = consider_suffix(i2, opts.to, round_method, precision)?;
Ok(match s {
None => {
format!(
Expand Down
6 changes: 1 addition & 5 deletions tests/by-util/test_numfmt.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1436,12 +1436,8 @@ fn test_zero_pad_sign_order_issue_11664() {
.stdout_is("-00000009869647.00\n");
}

// https://github.com/uutils/coreutils/issues/11666
// `--to-unit=N` selects the output prefix based on the unscaled value
// instead of `value / N`.
#[test]
#[ignore = "GNU compat: see uutils/coreutils#11666"]
fn test_to_unit_prefix_selection_issue_11666() {
fn test_to_unit_prefix_selection() {
new_ucmd!()
.args(&["--to=iec-i", "--to-unit=885", "100000"])
.succeeds()
Expand Down
Loading