Skip to content

cat: call pipe() once with multiple input#11699

Merged
sylvestre merged 1 commit into
uutils:mainfrom
oech3:cat-overkilled-pipes
Apr 20, 2026
Merged

cat: call pipe() once with multiple input#11699
sylvestre merged 1 commit into
uutils:mainfrom
oech3:cat-overkilled-pipes

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented Apr 7, 2026

Fixes #11698

Summary
  target/release/cat-reused-pipe /etc/* ran
    1.27 ± 0.25 times faster than target/release/cat /etc/*

@oech3 oech3 force-pushed the cat-overkilled-pipes branch from c1aaec2 to ca542cd Compare April 7, 2026 11:43
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 7, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)

@oech3 oech3 marked this pull request as ready for review April 7, 2026 12:09
Comment thread src/uu/cat/src/splice.rs Outdated
@oech3 oech3 force-pushed the cat-overkilled-pipes branch from ca542cd to 0275c40 Compare April 14, 2026 05:37
@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/expand/bounded-memory is now passing!

@oech3 oech3 requested a review from sylvestre April 14, 2026 06:05
@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Apr 20, 2026

Is this OK to merge?

@sylvestre sylvestre merged commit dc18b54 into uutils:main Apr 20, 2026
169 checks passed
@oech3 oech3 deleted the cat-overkilled-pipes branch April 20, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cat: overkilled pipe() call with multiple input

2 participants