fix(numfmt):fix precision loss for large numbers in #11654 by THEMIScale · Pull Request #11716 · uutils/coreutils

THEMIScale · 2026-04-08T17:08:11Z

Add numeric.rs to preserve precision for large integers
Modify related functions in format.rs
Adjust some float related test cases in format.rs
Large integer values are now accurate
Float precision remains limited by f64 and is worse than GNU
cargo test --features unix passes for numfmt

THEMIScale · 2026-04-08T17:20:16Z

There's a remaining problem here:

┌──(kali㉿KaliOnHP)-[~/coreutils]
└─$ ./target/debug/numfmt --from=iec 915339622.7555392131
915339622.7555391788

┌──(kali㉿KaliOnHP)-[~/coreutils]
└─$ /usr/bin/numfmt --from=iec 915339622.7555392131
915339622.7555392131

The f64 is not as precise as long double.
Even to igore the case, GNU numfmt still has an error when number is out of limitation(which WE don't):

┌──(kali㉿KaliOnHP)-[~/coreutils]
└─$ ./target/debug/numfmt --from=iec 915339622.7555392723748798127937497128934
915339622.7555392980575561523437500000000

┌──(kali㉿KaliOnHP)-[~/coreutils]
└─$ /usr/bin/numfmt --from=iec 915339622.7555392723748798127937497128934
numfmt: 值或精度过大，无法输出："9.1534e+08/31"（请考虑使用 --to）

If anyone see this, pls NEW an ISSUE if it is reasonable, I'm worrying that this PR won't be merged, thus my environment is not relyable for now.

github-actions · 2026-04-08T17:30:28Z

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/cp/link-heap is now being skipped but was previously passing.
Congrats! The gnu test tests/expand/bounded-memory is now passing!

cakebaker · 2026-04-09T06:46:22Z

I don't know if you have seen it: a few numfmt tests fail in the CI.

THEMIScale · 2026-04-09T07:00:48Z

Yeah, I just woke up and correct it.

github-actions · 2026-04-09T07:06:53Z

GNU testsuite comparison:

GNU test failed: tests/tail/tail-n0f. tests/tail/tail-n0f is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cut/cut-huge-range is now passing!

THEMIScale · 2026-04-09T07:43:56Z

will the fails be a problem? How can I run these failed checks again, I guess it might not be my problem. 🤔 @cakebaker

github-actions · 2026-04-09T12:13:15Z

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cp/link-heap is now passing!
Congrats! The gnu test tests/dd/no-allocate is now passing!
Congrats! The gnu test tests/seq/seq-epipe is now passing!

codspeed-hq · 2026-04-09T12:21:15Z

Merging this PR will not alter performance

✅ 309 untouched benchmarks
⏩ 46 skipped benchmarks¹

_{Comparing THEMIScale:main (c7c803e) with main (761add4)}

46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

cakebaker · 2026-04-09T12:27:06Z

will the fails be a problem?

No, you can ignore them, they are unrelated.

cakebaker · 2026-04-09T12:48:51Z

@@ -0,0 +1,26 @@
+// This file is written to solve #11654
+// This file is related to all code changes for GitHub Issue #11654.


This sentence is more or less the same as the previous sentence, so my suggestion is to remove it.

Suggested change

// This file is related to all code changes for GitHub Issue #11654.

github-actions · 2026-04-09T13:45:38Z

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cp/link-heap is now passing!
Congrats! The gnu test tests/dd/no-allocate is now passing!
Congrats! The gnu test tests/seq/seq-epipe is now passing!

github-actions · 2026-04-09T13:59:28Z

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cp/link-heap is now passing!
Congrats! The gnu test tests/dd/no-allocate is now passing!
Congrats! The gnu test tests/seq/seq-epipe is now passing!

cakebaker · 2026-04-09T14:19:08Z

@@ -479,14 +510,43 @@ fn consider_suffix(
        Ok((v, Some((suffixes[i - 1], with_i))))
    }
 }


A detail: I would add an empty line as a separator between the two functions.

Suggested change

}

}

cakebaker · 2026-04-09T14:29:29Z

    }
 }

+fn try_format_exact_int_without_output_scaling(


It looks like there is a mismatch between the function name and what the function does: the function name contains "without_output_scaling" whereas the function does some scaling. Maybe you can simply drop "without_output_scaling" from the name?

The function can be named more precisly afer try_format_exact_int_without_suffix_scaling, is it Ok?

Yes, it's an improvement.

github-actions · 2026-04-09T14:37:48Z

GNU testsuite comparison:

GNU test failed: tests/timeout/timeout-group. tests/timeout/timeout-group is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cp/link-heap is now passing!
Congrats! The gnu test tests/dd/no-allocate is now passing!
Congrats! The gnu test tests/seq/seq-epipe is now passing!

cakebaker · 2026-04-09T14:58:13Z

+fn try_scale_exact_int_without_suffix(
+    value: ParsedNumber,
+    from_unit: usize,
+    had_no_suffix: bool,


I would use a name without negation (and switch its meaning) to avoid the double negation on line 378.

Yes, that is a problem. I'm thinking to verify had_no_suffix in transform_from() , and change name of the function try_scale_exact_int_without_suffix into try_scale_exact_int_with_from_unit.

Yes, that might be an option.

…gation logic

github-actions · 2026-04-09T15:53:20Z

GNU testsuite comparison:

GNU test failed: tests/misc/io-errors. tests/misc/io-errors is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/dd/no-allocate is now being skipped but was previously passing.
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.
Note: The gnu test tests/tail/pipe-f is now being skipped but was previously passing.

THEMIScale · 2026-04-10T03:31:43Z

can my code be merged now?

github-actions · 2026-04-10T03:38:07Z

GNU testsuite comparison:

GNU test failed: tests/cp/sparse-to-pipe. tests/cp/sparse-to-pipe is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/tail/pid-pipe. tests/tail/pid-pipe is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/dd/no-allocate is now being skipped but was previously passing.
Note: The gnu test tests/rm/many-dir-entries-vs-OOM is now being skipped but was previously passing.
Skip an intermittent issue tests/tail/tail-n0f (was skipped on 'main', now failing)

github-actions · 2026-04-10T05:51:42Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/rm/many-dir-entries-vs-OOM is now being skipped but was previously passing.

cakebaker · 2026-04-10T08:15:16Z

Thanks!

fix(numfmt):fix recision loss for large numbers in uutils#11654

198d958

cakebaker changed the title ~~fix(numfmt):fix recision loss for large numbers in #11654~~ fix(numfmt):fix precision loss for large numbers in #11654 Apr 9, 2026

numfmt: fix some tests in format.rs caused by importing numeric.rs

c15e0bb

Merge branch 'main' into main

ca03730

cakebaker reviewed Apr 9, 2026

View reviewed changes

Comment thread src/uu/numfmt/src/numeric.rs

cakebaker reviewed Apr 9, 2026

View reviewed changes

add a file header and remove a redundant comment

ea35ae6

remove a redundant comment

1a7b790

cakebaker reviewed Apr 9, 2026

View reviewed changes

add a empty line between two functions

c2dc92f

cakebaker reviewed Apr 9, 2026

View reviewed changes

refactor(numfmt): rename helper functions for accuracy; fix double ne…

df7a0d9

…gation logic

Merge branch 'main' into main

c73b9a8

Merge branch 'main' into main

c7c803e

cakebaker merged commit ceacc67 into uutils:main Apr 10, 2026
169 checks passed

		@@ -0,0 +1,26 @@
		// This file is written to solve #11654
		// This file is related to all code changes for GitHub Issue #11654.

Uh oh!

Conversation

THEMIScale commented Apr 8, 2026

Uh oh!

THEMIScale commented Apr 8, 2026

Uh oh!

github-actions Bot commented Apr 8, 2026

Uh oh!

cakebaker commented Apr 9, 2026

Uh oh!

THEMIScale commented Apr 9, 2026

Uh oh!

github-actions Bot commented Apr 9, 2026

Uh oh!

THEMIScale commented Apr 9, 2026

Uh oh!

github-actions Bot commented Apr 9, 2026

Uh oh!

codspeed-hq Bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

cakebaker commented Apr 9, 2026

Uh oh!

Uh oh!

cakebaker Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 9, 2026

Uh oh!

github-actions Bot commented Apr 9, 2026

Uh oh!

cakebaker Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

cakebaker Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

THEMIScale Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

cakebaker Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 9, 2026

Uh oh!

cakebaker Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

THEMIScale Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

cakebaker Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 9, 2026

Uh oh!

THEMIScale commented Apr 10, 2026

Uh oh!

github-actions Bot commented Apr 10, 2026

Uh oh!

github-actions Bot commented Apr 10, 2026

Uh oh!

Uh oh!

cakebaker commented Apr 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codspeed-hq Bot commented Apr 9, 2026 •

edited

Loading

cakebaker Apr 9, 2026 •

edited

Loading

cakebaker Apr 9, 2026 •

edited

Loading