pr: exit with code 1 if --column argument is zero

[Devel08]

This pull request closes #11584 where --column shouldn't be zero.

$ cargo run pr --column=0 /etc/pacman.conf/
pr: invalid -column argument '0'

[github-actions]

GNU testsuite comparison:

GNU test failed: tests/tail/retry. tests/tail/retry is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/date/resolution (fails in this run but passes in the 'main' branch)

[oech3]

Can we do that at same code path with --column=-1 we already handled?

[Devel08]

@oech3 negative numbers are already handled, only numbers >= 0 could be used with --column

[oech3]

Can you merge this logic to there?

[Devel08]

@oech3 That was my first plan. I would if I Could, but I can't manage to find where that check is done, close the PR if that solution isn't appropriate as I cannot propose any other fix than that.

[oech3]

coreutils/src/uu/pr/src/pr.rs

Lines 780 to 783 in 2ab8e25

	let column_option_value = match parse_usize(matches, options::COLUMN) {
	Some(res) => Some(res?),
	None => start_column_option,
	};

parse_usize

[Devel08]

@oech3 yes, but parse_usize() is used for other purposes too, would it be safe to touch it?

[oech3]

Maybe, this match is better place to exclude 0 (instead of changing parse_usize)

[xtqqczze]

Maybe introduce a new function:

fn parse_nonzero_usize(matches: &ArgMatches, opt: &str) -> Option<Result<NonZero<usize>, PrError>>

[Devel08]

@oech3, I put the exit in the match

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/date/resolution (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/tail-n0f (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/tail/pipe-f is now being skipped but was previously passing.

[xtqqczze]

What about the NonZero<usize> approach?

[Devel08]

That -column mistake originates from the parse_usize() function

[sylvestre]

for a future pr, please use the translate!() macro for translation

[sylvestre]

same

[sylvestre]

ditto