Publish a comment in case of significant size change#11757
Merged
Conversation
Per-binary comparison script that reads the existing individual-size-result.json format (date-keyed with sha + sizes-in-KB) and reports binaries whose size changed by both >=5% and >=4 KB. This is the size-tracking counterpart of compare_test_results.py: it emits GitHub workflow annotations and writes a PR comment body to its --output path only when there is something significant to report.
Replace the inline shell loop that walked individual-size-result.json with a call to util/compare_size_results.py and write its output, plus the PR number, into a size-comment/ directory uploaded as an artifact. The aggregate `multiple binaries` and `multicall binary` checks remain inline since they are simple scalar comparisons. The new artifact is consumed by the SizeComment workflow to post a PR comment, mirroring the GnuTests / GnuComment pipeline.
New workflow mirroring GnuComment.yml: triggers on workflow_run of make, downloads the size-comment artifact for the corresponding PR, and posts the per-binary size comparison as a PR comment when there is something significant to report.
|
GNU testsuite comparison: |
sylvestre
force-pushed
the
ci-size
branch
3 times, most recently
from
4815a19 to
a222924
Compare
Mirrors test_compare_test_results.py: covers human_kb formatting, load_sizes (date-keyed and flat), compare() including threshold boundaries on both growth and shrinkage, format_report, and an end-to-end main() check that the comment file is only written when something significant is reported. Wired into code-quality.yml alongside the existing compare_test_results unit tests.
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.