date: fix the strftime O and E modifier leaks #11656 (new)#11834
Open
tobyw21 wants to merge 3 commits intouutils:mainfrom
Open
date: fix the strftime O and E modifier leaks #11656 (new)#11834tobyw21 wants to merge 3 commits intouutils:mainfrom
tobyw21 wants to merge 3 commits intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
Contributor
|
As I have previously discussed privately with the author about this issue, I'll be reviewing it. Pretty sure most of my initial comments have been addressed in the new PR, so I might not need to be super thorough. |
Alonely0
suggested changes
Apr 20, 2026
Contributor
There was a problem hiding this comment.
nitpick: for git etiquette reasons, I'd really appreciate it if you could move the comments added in the last commit to the implementation one, and squash the two commits adding tests into a single one. A clever interactive rebase should be enough, but don't hesitate to lmk if you'd like some guidance :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a new PR to a broken old PR #11714 and trying to address issue #11656.
This PR fixes date: strftime with O and E modifiers. Fixes #11656
Changes
coreutils/src/uu/date/src/format_modifiers.rs:105, in bytes matching, addedOandEbytes match.OandEmodifiers with valid specifier and invalid specifiers accordinggnu datebehaviours in the documentationLimitations
Currently block the
BrokenDownTimecallingto_string_with_configif modifierEorOcombines with invalid specifiers. It pre-checks if modifier isOorE, then skip formatting if modifier isEand specifier is not in '%c', '%C', '%x', '%X', '%y' and '%Y', or if modifier isOand specifier is in '%a', '%A', '%c', '%D', '%F', '%x' and '%X'. WhileJiffdoes not support modifierEandO, this check is to be done outside ofJiff.Build requirements
Rust stable
Testing
Tested with
make test