Skip to content

[splitting PR] fix collapsible_if#11852

Closed
oech3 wants to merge 1 commit intouutils:mainfrom
oech3:patch-1
Closed

[splitting PR] fix collapsible_if#11852
oech3 wants to merge 1 commit intouutils:mainfrom
oech3:patch-1

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented Apr 16, 2026

No description provided.

@oech3 oech3 marked this pull request as ready for review April 16, 2026 12:07
@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Apr 16, 2026

Oh...

@oech3 oech3 marked this pull request as draft April 16, 2026 12:22
@oech3 oech3 changed the title Cargo.toml: drop config for collapsible_if fix collapsible_if Apr 16, 2026
@xtqqczze
Copy link
Copy Markdown
Contributor

xtqqczze commented Apr 16, 2026

I've avoided fixing this automatically with clippy --fix as in many cases the code could be refactored for clarity.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 16, 2026

GNU testsuite comparison:

Note: The gnu test tests/cp/link-heap is now being skipped but was previously passing.
Note: The gnu test tests/rm/many-dir-entries-vs-OOM is now being skipped but was previously passing.
Note: The gnu test tests/tail/tail-n0f is now being skipped but was previously passing.

xtqqczze
xtqqczze reviewed Apr 16, 2026
View reviewed changes
Comment thread src/uucore/build.rs
if !target_util.is_empty() {
return Some(target_util);
}
if let Ok(target_util) = env::var("UUCORE_TARGET_UTIL")
Copy link
Copy Markdown
Contributor

@xtqqczze xtqqczze Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function could be turned into an Option pipeline, chaining with or_else.

@xtqqczze
Copy link
Copy Markdown
Contributor

xtqqczze commented Apr 16, 2026

The PR would be too big to fix all the cases at once.

@oech3 oech3 changed the title fix collapsible_if [splitting PR] fix collapsible_if Apr 16, 2026
@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Apr 16, 2026

ok

@oech3 oech3 closed this Apr 16, 2026
@oech3 oech3 deleted the patch-1 branch April 16, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@xtqqczze xtqqczze xtqqczze left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oech3 @xtqqczze