Skip to content

replace memchr with bytecount#11872

Closed
xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:bytecount
Closed

replace memchr with bytecount#11872
xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:bytecount

Conversation

@xtqqczze
Copy link
Copy Markdown
Contributor

No description provided.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 17, 2026

Merging this PR will not alter performance

✅ 309 untouched benchmarks
⏩ 46 skipped benchmarks1


Comparing xtqqczze:bytecount (c4fed3f) with main (3194190)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 17, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/misc/io-errors is no longer failing!
Note: The gnu test tests/cut/cut-huge-range is now being skipped but was previously passing.
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.

@oech3
Copy link
Copy Markdown
Contributor

oech3 commented Apr 17, 2026

I'm considering to replace cat bench with head bench for this.
cat bench cannot be used for non-linux since it uses splice().
head -n cannot splice.

@oech3

This comment was marked as resolved.

@xtqqczze xtqqczze changed the title replace memchr with bytecount for improved performance replace memchr with bytecount Apr 17, 2026
@xtqqczze
Copy link
Copy Markdown
Contributor Author

Merging this PR will not alter performance

That's surprising since replacing bytecount with memchr was a regression: #11871.

@xtqqczze xtqqczze closed this Apr 17, 2026
@xtqqczze xtqqczze deleted the bytecount branch April 17, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants