Skip to content

fix(sort): explicitly clean up temp directory in TmpDirWrapper::Drop #11888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sylvestre merged 1 commit into from
Apr 18, 2026
Merged

fix(sort): explicitly clean up temp directory in TmpDirWrapper::Drop #11888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/uu/sort/src/tmp_dir.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,15 @@ impl Drop for TmpDirWrapper {
guard.lock = None;
guard.path = None;
}
drop(guard);

// Explicitly attempt cleanup before TempDir's Drop runs silently.
// TempDir::drop uses `let _ = remove_dir_all()` which silently
// ignores errors, potentially leaking the directory.
#[cfg(not(any(target_os = "redox", target_os = "wasi")))]
if let Some(ref temp_dir) = self.temp_dir {
let _ = remove_tmp_dir(temp_dir.path());
}
}
}

Expand Down
Loading