du: Allow command-line argument that appears more than once#11897
Merged
sylvestre merged 16 commits intouutils:mainfrom Apr 20, 2026
Merged
du: Allow command-line argument that appears more than once#11897sylvestre merged 16 commits intouutils:mainfrom
sylvestre merged 16 commits intouutils:mainfrom
Conversation
Contributor
Author
|
I discovered from the CI/CD test that NO_DEREFERENCE was correct to begin with. Undid my "fix". |
Contributor
|
please add a test that verify all these changes to make sure we don't regress in the future |
|
GNU testsuite comparison: |
cakebaker
reviewed
Apr 20, 2026
cakebaker
reviewed
Apr 20, 2026
cakebaker
reviewed
Apr 20, 2026
cakebaker
reviewed
Apr 20, 2026
cakebaker
reviewed
Apr 20, 2026
cakebaker
reviewed
Apr 20, 2026
Merging this PR will improve performance by 3.02%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | du_max_depth_balanced_tree[(6, 4, 10)] |
25.8 ms | 25 ms | +3.02% |
Comparing ajanicij:ajanicij/du-accept-repeated-argument (d21d3b6) with main (34fd4be)
Footnotes
-
46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Contributor
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for 1173: du: error: the argument '--human-readable' cannot be used multiple times (but works in GNU).