Skip to content

tee: move fn write_flush to NamedWriter#11940

Closed
oech3 wants to merge 1 commit intouutils:mainfrom
oech3:tee-wf
Closed

tee: move fn write_flush to NamedWriter#11940
oech3 wants to merge 1 commit intouutils:mainfrom
oech3:tee-wf

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented Apr 22, 2026

Required by #11466

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/unexpand/bounded-memory is now passing!

@oech3 oech3 marked this pull request as ready for review April 22, 2026 06:25
@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Apr 22, 2026

Increasing lines. Very bad...

@cakebaker
Copy link
Copy Markdown
Contributor

Increasing lines. Very bad...

I wouldn't worry too much about that as the increase is small ;-)

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Apr 22, 2026

I think I duplicate many code about error handling when I try to support splice().
But I have no idea how to avoid it since

let mut aborted = None;
let mut errors = 0;

is not part of NamedWriter.

@oech3 oech3 marked this pull request as draft April 22, 2026 10:36
@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Apr 22, 2026

I'll reconsider this after #11466

@oech3 oech3 closed this Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants