Skip to content

pipes.rs: add debug_assert! for RAM usage#11994

Merged
cakebaker merged 1 commit intouutils:mainfrom
oech3:ram-assert
Apr 25, 2026
Merged

pipes.rs: add debug_assert! for RAM usage#11994
cakebaker merged 1 commit intouutils:mainfrom
oech3:ram-assert

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented Apr 25, 2026

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 25, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/symlink (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/dd/no-allocate is now being skipped but was previously passing.

@oech3 oech3 marked this pull request as ready for review April 25, 2026 11:59
@cakebaker
Copy link
Copy Markdown
Contributor

cakebaker commented Apr 25, 2026

What's the reason for adding those debug_assert statements?

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Apr 25, 2026 •
edited
Loading

Because

  • bounded RAM usage is unclear for me if I see those code only.
  • Linux kernel might change MAX_ROOTLESS_PIPE_SIZE to infinity in the future and someone might make this to unbounded when it happened.

@cakebaker cakebaker merged commit e50f0d0 into uutils:main Apr 25, 2026
166 of 167 checks passed
@cakebaker
Copy link
Copy Markdown
Contributor

cakebaker commented Apr 25, 2026

Ok, thanks!

@oech3 oech3 deleted the ram-assert branch April 25, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oech3 @cakebaker