Skip to content

refactor(pinky): improve output handling#12002

Merged
cakebaker merged 1 commit intouutils:mainfrom
xtqqczze:GH11970
Apr 27, 2026
Merged

refactor(pinky): improve output handling#12002
cakebaker merged 1 commit intouutils:mainfrom
xtqqczze:GH11970

Conversation

@xtqqczze
Copy link
Copy Markdown
Contributor

@xtqqczze xtqqczze commented Apr 26, 2026

Closes #10562
Closes #11970

Summary

  • All output now goes through the provided writer instead of global stdout macros.
  • All functions now propagate io::Result<()> instead of panicking on error.
  • Use std::io::copy, which removes buffering + manual buffer + UTF-8 conversion.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 26, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)

@xtqqczze xtqqczze force-pushed the GH11970 branch 2 times, most recently from 7063d0a to b793dcc Compare April 26, 2026 02:16
@xtqqczze xtqqczze force-pushed the GH11970 branch 2 times, most recently from 7a21ead to ce84206 Compare April 26, 2026 02:54
Co-authored-by: penelope zhong <penelope.zhong@proton.me>
@xtqqczze xtqqczze marked this pull request as ready for review April 26, 2026 04:51
@xtqqczze
Copy link
Copy Markdown
Contributor Author

@oech3 any issues with using std::io::copy here?

@oech3
Copy link
Copy Markdown
Contributor

oech3 commented Apr 27, 2026

If it does not use FUSE, maybe OK.

@cakebaker cakebaker merged commit d926a67 into uutils:main Apr 27, 2026
166 of 167 checks passed
@cakebaker
Copy link
Copy Markdown
Contributor

Thanks!

@xtqqczze
Copy link
Copy Markdown
Contributor Author

@hideyosh1 Thanks for you contribution.

@xtqqczze xtqqczze deleted the GH11970 branch April 27, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pinky > /dev/full panics

3 participants