numfmt: reject %f values too large to format exactly#12012
Open
pocopepe wants to merge 1 commit intouutils:mainfrom
Open
numfmt: reject %f values too large to format exactly#12012pocopepe wants to merge 1 commit intouutils:mainfrom
pocopepe wants to merge 1 commit intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
cakebaker
reviewed
Apr 27, 2026
| fn format_gnu_scientific(v: f64) -> String { | ||
| // 6 significant figures with trimmed trailing zeros and signed exponent | ||
| let s = format!("{v:.5e}"); | ||
| if let Some(e_pos) = s.find('e') { |
Contributor
There was a problem hiding this comment.
A detail: I would use an early return with let-else to get rid of the outer else block. Something like:
let Some(e_pos) = s.find('e') else {
return s;
};
sylvestre
reviewed
Apr 28, 2026
| let scaled = integer / to_unit; | ||
|
|
||
| Some(if precision == 0 { | ||
| // reject when formatted output would need 20+ digits |
Contributor
There was a problem hiding this comment.
can you please move this check into a new function?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11936
%N.Mfwas silently lossy for very large ints via the f64 path. Now bails out when the value would need 20+ digits to print, like GNU does.