Skip to content

sort: improve performance for very long lines (#12138)#12193

Closed
sylvestre wants to merge 1 commit intouutils:mainfrom
sylvestre:sort-per-impl
Closed

sort: improve performance for very long lines (#12138)#12193
sylvestre wants to merge 1 commit intouutils:mainfrom
sylvestre:sort-per-impl

Conversation

@sylvestre
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/tail-n0f (passes in this run but fails in the 'main' branch)

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 7, 2026

Merging this PR will degrade performance by 3.9%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 315 untouched benchmarks
⏩ 46 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation sort_long_line[10000] 423.1 µs 409 µs +3.46%
Simulation sort_key_field[500000] 767.8 ms 799 ms -3.9%

Comparing sylvestre:sort-per-impl (dec19b3) with main (485b156)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3
Copy link
Copy Markdown
Contributor

oech3 commented May 8, 2026

see #12150 and #12144

@sylvestre
Copy link
Copy Markdown
Contributor Author

Oh, missed them. Thanks

@sylvestre sylvestre closed this May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants