Skip to content

dd: refactor stdio handling#12210

Draft
xtqqczze wants to merge 1 commit intouutils:mainfrom
xtqqczze:dd-stdin-raw
Draft

dd: refactor stdio handling#12210
xtqqczze wants to merge 1 commit intouutils:mainfrom
xtqqczze:dd-stdin-raw

Conversation

@xtqqczze
Copy link
Copy Markdown
Contributor

@xtqqczze xtqqczze commented May 10, 2026

  • Introduce a StdinRaw wrapper backed by ManuallyDrop<File> to prevent the stdin file descriptor from being closed on drop, which could otherwise lead to undefined behavior.
  • Introduce a StdoutRaw wrapper to avoid unnecessarily cloning the file descriptor as much as possible.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 10, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/tail/retry (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/seq/seq-epipe is now being skipped but was previously passing.
Congrats! The gnu test tests/pr/bounded-memory is now passing!

@xtqqczze xtqqczze force-pushed the dd-stdin-raw branch 3 times, most recently from c2a52d4 to 07699da Compare May 10, 2026 01:47
@xtqqczze

This comment was marked as outdated.

@xtqqczze xtqqczze changed the title dd: refactor stdin handling to use StdinRaw struct dd: refactor stdio handling May 10, 2026
@xtqqczze xtqqczze force-pushed the dd-stdin-raw branch 5 times, most recently from d3ac1c9 to 32d72c4 Compare May 10, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant